[GitHub] [nifi] exceptionfactory commented on pull request #7170: NIFI-11440: Speed up Hive Metastore based unit tests

2023-04-14 Thread via GitHub


exceptionfactory commented on PR #7170:
URL: https://github.com/apache/nifi/pull/7170#issuecomment-1508798033

   Thanks for making the adjustments @mark-bathori! I started the automated 
build and will plan on merging pending successful completion on all platforms.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] exceptionfactory commented on pull request #7170: NIFI-11440: Speed up Hive Metastore based unit tests

2023-04-13 Thread via GitHub


exceptionfactory commented on PR #7170:
URL: https://github.com/apache/nifi/pull/7170#issuecomment-1507581057

   > I would advise not to waste any time bothering with these tests on 
Windows. I'd just detect running on windows and ignore them.
   
   I concur, the tests are already disabled on Windows, so promoting the 
annotation from method level to class level seems like the best path forward.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org