[GitHub] [nifi] lawye1973 commented on pull request #5774: NIFI-9696 : DeleteS3Object don't have provenance
lawye1973 commented on pull request #5774: URL: https://github.com/apache/nifi/pull/5774#issuecomment-1043013360 Too many conflicts between master and main branch. Closing this PR and open a new PR directly from main branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] lawye1973 commented on pull request #5774: NIFI-9696 : DeleteS3Object don't have provenance
lawye1973 commented on pull request #5774: URL: https://github.com/apache/nifi/pull/5774#issuecomment-1042859942 @pvillard31 / @markap14 , I'd managed to change the base to apache/main. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] lawye1973 commented on pull request #5774: NIFI-9696 : DeleteS3Object don't have provenance
lawye1973 commented on pull request #5774: URL: https://github.com/apache/nifi/pull/5774#issuecomment-1042744437 > @lawye1973 this PR is also set to merge into the `master` branch. But that branch hasn't been used in a long time. Please create with an upstream branch of `main`. @markap14 , it'll be a different PR from this, right ? i don't think i can rebase this to main branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] lawye1973 commented on pull request #5774: NIFI-9696 : DeleteS3Object don't have provenance
lawye1973 commented on pull request #5774: URL: https://github.com/apache/nifi/pull/5774#issuecomment-1041401598 > @lawye1973 Thank you for implementing this missing feature! > > `SEND` event is for indicating a provenance event for sending data to an external system. Please use `REMOTE_INVOCATION` instead, like in case of [DeleteHDFS](https://github.com/apache/nifi/blob/67880765365e033d0d772f5c7b5c2e2186a1086c/nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/DeleteHDFS.java#L179) or [DeleteAzureDatalakeStorege](https://github.com/apache/nifi/blob/67880765365e033d0d772f5c7b5c2e2186a1086c/nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/DeleteAzureDataLakeStorage.java#L104). Thanks! @turcsanyip , thanks for the guidance. I'd updated the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
