[GitHub] [nifi] markobean commented on pull request #5324: NIFI-9072: improvements to ValidateXML including validate XML in attr…
markobean commented on pull request #5324: URL: https://github.com/apache/nifi/pull/5324#issuecomment-1051183565 Thanks @markap14 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] markobean commented on pull request #5324: NIFI-9072: improvements to ValidateXML including validate XML in attr…
markobean commented on pull request #5324: URL: https://github.com/apache/nifi/pull/5324#issuecomment-1051087898 The character set issue pointed out by @exceptionfactory refers to the getBytes() call when reading an attribute value. Yet, @markap14 suggests using the proposed character set property only for flowfile content. However, for content, this processor uses Java classes accepting InputStream, not a character set-specific String. Additionally, this processor is not generating or modifying content. I don't think the character set is relevant in order to accurately parse XML. IMO, we're getting into issues of relevance and scope creep for this ticket. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] markobean commented on pull request #5324: NIFI-9072: improvements to ValidateXML including validate XML in attr…
markobean commented on pull request #5324: URL: https://github.com/apache/nifi/pull/5324#issuecomment-1036460776 I am a -1 for an additional `ValidateXMLAttribute` processor. Such a processor adds to processor bloat, and it does not solve any of the current resistance outlined in this PR. In fact, it creates more problems than it solves. Another negative to such a named processor is the increased visibility into the fact that XML in attributes is supported. This will only exacerbate the concerns of uninformed users voiced by @markap14. Another nudge to the +1 direction of this PR is the fact that the processor handles attributes is not obvious unless/until a user looks at the configuration options and documentation. And, to be explicit, the processor documentation clearly has a warning for use of large attribute values by making use of the `@SystemResourceConsideration`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] markobean commented on pull request #5324: NIFI-9072: improvements to ValidateXML including validate XML in attr…
markobean commented on pull request #5324: URL: https://github.com/apache/nifi/pull/5324#issuecomment-1033290551 @markap14 I do not disagree with any points your have made about the dangers of using large attributes. Also, thanks for detailing the reasons of why this can be a problem for other users who may not be aware. Rest assured, these were all considerations and well within the understanding and scope of the use case which drove this ticket. We have never had OOM issues, and the usage is for approximately 200 FlowFiles per day with reasonably sized XML attributes. I appreciate the necessity to prevent “bad things” happening as much as possible. While I respectfully disagree with limiting the platform out of fear of self-induced problems, I understand such problems do occur in the real world. Since NiFi is easily extensible, we will apply these changes to a custom processor to satisfy the specific case without injecting it to the NiFi community. @joewitt I hear what you’re saying about being inconsistent. A prime example related to this PR for processing XML in attributes is available right in Expression Language. It has functions such as (un)escapeXml, and also (un)escapeJson and (un)escapeHtml. It seems the availability of these functions promotes placing XML (or JSON or HTML) into attributes equally as much as this PR, or even more since EL can be applied to a wide variety of processors. EL even has other jsonPath* functions whose simple examples in the EL Guide include 300-500 character JSON strings. Perhaps these examples should be updated to simpler JSON more consistent with the recommended limitation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] markobean commented on pull request #5324: NIFI-9072: improvements to ValidateXML including validate XML in attr…
markobean commented on pull request #5324: URL: https://github.com/apache/nifi/pull/5324#issuecomment-1031801195 Pinging once again. I think all discussions have been resolved and this is ready to be merged. Are there any outstanding issues that I'm not seeing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] markobean commented on pull request #5324: NIFI-9072: improvements to ValidateXML including validate XML in attr…
markobean commented on pull request #5324: URL: https://github.com/apache/nifi/pull/5324#issuecomment-1025168745 Still looking for a committer to wrap up this PR. There are no outstanding change requests. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] markobean commented on pull request #5324: NIFI-9072: improvements to ValidateXML including validate XML in attr…
markobean commented on pull request #5324: URL: https://github.com/apache/nifi/pull/5324#issuecomment-1014903291 Using ReplaceText goes against the purpose of this ticket. Already, the content of a FlowFile can be validated. However, this ticket is to allow the contents of an attribute to be validated. Use case: an attribute contains metadata about the content; this metadata is in XML format. See the original JIRA ticket for an example use case. I understand Mark's reservations, and I share them. Large XML documents should be avoided in attributes. However, responsible usage of attributes and "reasonably sized" XML provides an opportunity here. Also, there is support of this feature by @mosermw in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] markobean commented on pull request #5324: NIFI-9072: improvements to ValidateXML including validate XML in attr…
markobean commented on pull request #5324: URL: https://github.com/apache/nifi/pull/5324#issuecomment-1009986427 The request to use `SafeXMLConfiguration` as been completed. I performed a force-push because I rebased to current `main`. This seems to have prevented me from marking the request as resolved - but it is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
