[GitHub] [nifi] mattyb149 commented on pull request #6035: NIFI-9440 Allow Controller Services to have configurable Bulletins

2022-06-28 Thread GitBox


mattyb149 commented on PR #6035:
URL: https://github.com/apache/nifi/pull/6035#issuecomment-1168821231

   +1 LGTM, I was able to verify on a couple of scenarios. Thanks for the 
improvement and for sticking with this PR! Merging to main


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] mattyb149 commented on pull request #6035: NIFI-9440 Allow Controller Services to have configurable Bulletins

2022-06-06 Thread GitBox


mattyb149 commented on PR #6035:
URL: https://github.com/apache/nifi/pull/6035#issuecomment-1147524642

   I'm having trouble validating this, I tried with an IPLookupService as 
described in the Jira, but leaving the MaxMind file blank just makes the CS 
invalid as this is a required property. How do I set this up so I can see the 
bulletins, and where should I see them? Thanks! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] mattyb149 commented on pull request #6035: NIFI-9440 Allow Controller Services to have configurable Bulletins

2022-05-26 Thread GitBox


mattyb149 commented on PR #6035:
URL: https://github.com/apache/nifi/pull/6035#issuecomment-1138649678

   There are merge conflicts now that need to be resolved, then I will review, 
thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org