[GitHub] [nifi] r-sidd commented on pull request #7341: NIFI-11643: Upgrade geoip2 to 4.0.1

2023-06-06 Thread via GitHub


r-sidd commented on PR #7341:
URL: https://github.com/apache/nifi/pull/7341#issuecomment-1579861542

   > Thanks @r-sidd, this upgrade looks good for the main branch. This cannot 
be backported to the support branch due to Java 11 requirements, but this is 
helpful for the next major release version. +1 merging
   
   Cool 﫡


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] r-sidd commented on pull request #7341: NIFI-11643: Upgrade geoip2 to 4.0.1

2023-06-05 Thread via GitHub


r-sidd commented on PR #7341:
URL: https://github.com/apache/nifi/pull/7341#issuecomment-1577883822

   > Version 4.0.1 includes changes from 
[3.0.0](https://github.com/maxmind/GeoIP2-java/releases/tag/v3.0.0) that 
require Java 11 as the minimum version, so this should be suitable for 
inclusion on the main branch, but cannot be backported to the version 1 support 
branch.
   
   Cool, how should we go about it 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org