[GitHub] [nifi] scottyaslan commented on a change in pull request #5060: NIFI-8520 - Parameter Contexts - Show the wrong information of referencing compon…
scottyaslan commented on a change in pull request #5060:
URL: https://github.com/apache/nifi/pull/5060#discussion_r633759203
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-parameter-contexts.js
##
@@ -2397,8 +2397,6 @@
* @param parameterToSelect Optional, name of the parameter to
select in the table.
*/
showParameterContext: function (id, readOnly, parameterToSelect) {
-parameterCount = 0;
Review comment:
By not resetting this count each time the parameter context table is
displayed the count now grows each time the dialog is opened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] scottyaslan commented on a change in pull request #5060: NIFI-8520 - Parameter Contexts - Show the wrong information of referencing compon…
scottyaslan commented on a change in pull request #5060:
URL: https://github.com/apache/nifi/pull/5060#discussion_r633713204
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-parameter-contexts.js
##
@@ -2397,8 +2397,6 @@
* @param parameterToSelect Optional, name of the parameter to
select in the table.
*/
showParameterContext: function (id, readOnly, parameterToSelect) {
-parameterCount = 0;
Review comment:
I have tested this and it works as advertised but I can't figure out
why this works or what the original issue is...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] scottyaslan commented on a change in pull request #5060: NIFI-8520 - Parameter Contexts - Show the wrong information of referencing compon…
scottyaslan commented on a change in pull request #5060:
URL: https://github.com/apache/nifi/pull/5060#discussion_r633713204
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-parameter-contexts.js
##
@@ -2397,8 +2397,6 @@
* @param parameterToSelect Optional, name of the parameter to
select in the table.
*/
showParameterContext: function (id, readOnly, parameterToSelect) {
-parameterCount = 0;
Review comment:
I have tested this and it works as advertised but I can't figure out
why this works or what the original issue is...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] scottyaslan commented on a change in pull request #5060: NIFI-8520 - Parameter Contexts - Show the wrong information of referencing compon…
scottyaslan commented on a change in pull request #5060:
URL: https://github.com/apache/nifi/pull/5060#discussion_r632740807
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-parameter-contexts.js
##
@@ -2397,8 +2397,6 @@
* @param parameterToSelect Optional, name of the parameter to
select in the table.
*/
showParameterContext: function (id, readOnly, parameterToSelect) {
-parameterCount = 0;
Review comment:
This is needed as the count gets reset every time the
`#parameter-context-dialog` is opened and this count is used to track the index
of any new parameters. Instead of removing this line try calling `resetUsage()`
before we reset the `parameterCount = 0;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
