[GitHub] [nifi] thenatog commented on pull request #5701: NIFI-9607: Honor Update Keys when Quoting Identifiers in PutDatabaseRecord

2022-02-16 Thread GitBox


thenatog commented on pull request #5701:
URL: https://github.com/apache/nifi/pull/5701#issuecomment-1042310893


   +1 will merge. If we can get more information/a specific case where the 
issue mentioned by mi-volodin we can create another Jira to resolve it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] thenatog commented on pull request #5701: NIFI-9607: Honor Update Keys when Quoting Identifiers in PutDatabaseRecord

2022-02-15 Thread GitBox


thenatog commented on pull request #5701:
URL: https://github.com/apache/nifi/pull/5701#issuecomment-1041019167


   I tested out these changes and they look good to me. I wasn't sure if we 
want to include the changes mi-volodin suggested as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] thenatog commented on pull request #5701: NIFI-9607: Honor Update Keys when Quoting Identifiers in PutDatabaseRecord

2022-02-15 Thread GitBox


thenatog commented on pull request #5701:
URL: https://github.com/apache/nifi/pull/5701#issuecomment-1040463251


   Will review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] thenatog commented on pull request #5701: NIFI-9607: Honor Update Keys when Quoting Identifiers in PutDatabaseRecord

2022-02-15 Thread GitBox


thenatog commented on pull request #5701:
URL: https://github.com/apache/nifi/pull/5701#issuecomment-1040463251


   Will review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org