[GitHub] [nifi] turcsanyip commented on pull request #5692: NIFI-9609 Added nifi-snowflake-bundle with a SnowflakeConnectionPool.
turcsanyip commented on pull request #5692: URL: https://github.com/apache/nifi/pull/5692#issuecomment-1047209429 @exceptionfactory It looks good to me now. I also tested it a bit with Snowflake and it works properly. There are two minor typos in the description of `Snowflake URL` property: _"can can have"_ and _"TABLe"_ These could also be fixed during the merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] turcsanyip commented on pull request #5692: NIFI-9609 Added nifi-snowflake-bundle with a SnowflakeConnectionPool.
turcsanyip commented on pull request #5692: URL: https://github.com/apache/nifi/pull/5692#issuecomment-1039276217 @tpalfy Please do not forget to add LICENCE / NOTICE files in the nar bundle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] turcsanyip commented on pull request #5692: NIFI-9609 Added nifi-snowflake-bundle with a SnowflakeConnectionPool.
turcsanyip commented on pull request #5692: URL: https://github.com/apache/nifi/pull/5692#issuecomment-1039276217 @tpalfy Please do not forget to add LICENCE / NOTICE files in the nar bundle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] turcsanyip commented on pull request #5692: NIFI-9609 Added nifi-snowflake-bundle with a SnowflakeConnectionPool.
turcsanyip commented on pull request #5692: URL: https://github.com/apache/nifi/pull/5692#issuecomment-1021056412 @tpalfy @exceptionfactory Regarding nar/jar dependencies, I believe the following should work: - declare `nifi-dbcp-service-nar` as the parent nar of the new `nifi-snowflake-service-nar` bundle (all classes in jars bundled in the parent will be available for the child at runtime) - add `nifi-dbcp-service` (jar) dependency in `nifi-snowflake-service` as `provided` (=> you can inherit from the class but ServiceLoader will not initialize duplicated service classes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] turcsanyip commented on pull request #5692: NIFI-9609 Added nifi-snowflake-bundle with a SnowflakeConnectionPool.
turcsanyip commented on pull request #5692: URL: https://github.com/apache/nifi/pull/5692#issuecomment-1021056412 @tpalfy @exceptionfactory Regarding nar/jar dependencies, I believe the following should work: - declare `nifi-dbcp-service-nar` as the parent nar of the new `nifi-snowflake-service-nar` bundle (all classes in jars bundled in the parent will be available for the child at runtime) - add `nifi-dbcp-service` (jar) dependency in `nifi-snowflake-service` as `provided` (=> you can inherit from the class but ServiceLoader will not initialize duplicated service classes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
