[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1555: MINIFICPP-2097 Fix build failure when ENABLE_ALL is ON
fgerlits commented on code in PR #1555: URL: https://github.com/apache/nifi-minifi-cpp/pull/1555#discussion_r1165117425 ## extensions/script/CMakeLists.txt: ## Review Comment: I have created Jira https://issues.apache.org/jira/browse/MINIFICPP-2098 as a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1555: MINIFICPP-2097 Fix build failure when ENABLE_ALL is ON
fgerlits commented on code in PR #1555: URL: https://github.com/apache/nifi-minifi-cpp/pull/1555#discussion_r1164462363 ## extensions/script/CMakeLists.txt: ## Review Comment: That's a different issue, because they don't cause a build failure, unlike this one. I don't want `ENABLE_ALL` to enable Tensorflow, because that needs special libraries to build, but I can enable the rest of them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
