[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1059: MINIFICPP-1510 Register and fix InvokeHTTPTests

2021-04-26 Thread GitBox 


lordgamez commented on a change in pull request #1059:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1059#discussion_r620222683



##
File path: extensions/http-curl/tests/unit/InvokeHTTPTests.cpp
##
@@ -307,6 +315,6 @@ TEST_CASE("HTTPTestsPostNoResourceClaim", "[httptest1]") {
 REQUIRE(provEventRecord->getComponentType() == processor->getName());

Review comment:
   Removed unused `getCurrentFlowFile` calls in 
50926ed98c23a14b8f7113563aeb887aacb6678d




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1059: MINIFICPP-1510 Register and fix InvokeHTTPTests

2021-04-26 Thread GitBox 


lordgamez commented on a change in pull request #1059:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1059#discussion_r620222408



##
File path: extensions/http-curl/tests/unit/InvokeHTTPTests.cpp
##
@@ -270,19 +276,21 @@ TEST_CASE("HTTPTestsWithResourceClaimPOST", 
"[httptest1]") {
 REQUIRE(provEventRecord->getComponentType() == listenhttp->getName());
   }
   std::shared_ptr ffr = session2->get();
-  REQUIRE(true == LogTestController::getInstance().contains("exiting because 
method is POST"));
+  REQUIRE(true == LogTestController::getInstance().contains("Exiting because 
method is POST"));
   LogTestController::getInstance().reset();
 }
 
 TEST_CASE("HTTPTestsPostNoResourceClaim", "[httptest1]") {
   TestController testController;
-  
LogTestController::getInstance().setInfo();
-  
LogTestController::getInstance().setInfo();
+  
LogTestController::getInstance().setDebug();
+  
LogTestController::getInstance().setDebug();
   LogTestController::getInstance().setInfo();
 
   std::shared_ptr plan = testController.createPlan();
   std::shared_ptr processor = 
plan->addProcessor("ListenHTTP", "listenhttp", core::Relationship("No Retry", 
"description"), false);

Review comment:
   Updated in 2f0d785b5ca87a468f64238d669bc5a447321b01




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1059: MINIFICPP-1510 Register and fix InvokeHTTPTests

2021-04-26 Thread GitBox 


lordgamez commented on a change in pull request #1059:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1059#discussion_r620055279



##
File path: extensions/http-curl/tests/unit/InvokeHTTPTests.cpp
##
@@ -270,19 +276,21 @@ TEST_CASE("HTTPTestsWithResourceClaimPOST", 
"[httptest1]") {
 REQUIRE(provEventRecord->getComponentType() == listenhttp->getName());
   }
   std::shared_ptr ffr = session2->get();
-  REQUIRE(true == LogTestController::getInstance().contains("exiting because 
method is POST"));
+  REQUIRE(true == LogTestController::getInstance().contains("Exiting because 
method is POST"));
   LogTestController::getInstance().reset();
 }
 
 TEST_CASE("HTTPTestsPostNoResourceClaim", "[httptest1]") {
   TestController testController;
-  
LogTestController::getInstance().setInfo();
-  
LogTestController::getInstance().setInfo();
+  
LogTestController::getInstance().setDebug();

Review comment:
   In the test we are checking for "Exiting because method is POST" log 
message which is a debug log, so we have to modify the log level to be able to 
assert on that. It was probably an info level log previously and changed later.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1059: MINIFICPP-1510 Register and fix InvokeHTTPTests

2021-04-23 Thread GitBox 


lordgamez commented on a change in pull request #1059:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1059#discussion_r619231323



##
File path: extensions/http-curl/tests/CMakeLists.txt
##
@@ -40,8 +40,8 @@ FOREACH(testfile ${CURL_UNIT_TESTS})
target_wholearchive_library(${testfilename} minifi-civet-extensions)
target_wholearchive_library(${testfilename} minifi-standard-processors)
 
-   MATH(EXPR CURL_INT_TEST_COUNT "${CURL_INT_TEST_COUNT}+1")
-#   add_test(NAME "${testfilename}" COMMAND "${testfilename}" 
WORKING_DIRECTORY ${TEST_DIR})
+   MATH(EXPR CURL_INT_TEST_COUNT "${CURL_INT_TEST_COUNT}+1")

Review comment:
   I removed the leading space which made the row alignment correct in my 
editor and I did not notice there was another leading space remaining. I 
replaced all leading spaces with tabs in 
7d2ce7d94bc3ce060822f6cf3bf0f770c7b36bde




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1059: MINIFICPP-1510 Register and fix InvokeHTTPTests

2021-04-23 Thread GitBox 


lordgamez commented on a change in pull request #1059:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1059#discussion_r619231323



##
File path: extensions/http-curl/tests/CMakeLists.txt
##
@@ -40,8 +40,8 @@ FOREACH(testfile ${CURL_UNIT_TESTS})
target_wholearchive_library(${testfilename} minifi-civet-extensions)
target_wholearchive_library(${testfilename} minifi-standard-processors)
 
-   MATH(EXPR CURL_INT_TEST_COUNT "${CURL_INT_TEST_COUNT}+1")
-#   add_test(NAME "${testfilename}" COMMAND "${testfilename}" 
WORKING_DIRECTORY ${TEST_DIR})
+   MATH(EXPR CURL_INT_TEST_COUNT "${CURL_INT_TEST_COUNT}+1")

Review comment:
   I removed the leading space which made the row alignment correct in my 
editor and I did not notice there was another leading space left. Replaced all 
leading spaces with tabs in 7d2ce7d94bc3ce060822f6cf3bf0f770c7b36bde




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1059: MINIFICPP-1510 Register and fix InvokeHTTPTests

2021-04-23 Thread GitBox 


lordgamez commented on a change in pull request #1059:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1059#discussion_r619137647



##
File path: extensions/http-curl/tests/CMakeLists.txt
##
@@ -68,6 +68,7 @@ message("-- Finished building ${CURL_INT_TEST_COUNT} libcURL 
integration test fi
 
 add_test(NAME HTTPClientTests COMMAND "HTTPClientTests" WORKING_DIRECTORY 
${TEST_DIR})
 add_test(NAME HTTPStreamingCallbackTests COMMAND "HTTPStreamingCallbackTests" 
WORKING_DIRECTORY ${TEST_DIR})
+add_test(NAME InvokeHTTPTests COMMAND "InvokeHTTPTests" WORKING_DIRECTORY 
${TEST_DIR})

Review comment:
   Good catch! Updated in 5291683b4341a0a5ae787785458df8b414cb0cda




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org