[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1511: MINIFICPP-1716 Recover core dumps from CI

2023-03-21 Thread via GitHub 


lordgamez commented on code in PR #1511:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1511#discussion_r1143910399


##
.github/workflows/ci.yml:
##
@@ -39,9 +39,26 @@ jobs:
   # CPPFLAGS are not recognized by cmake, so we have to force them to 
CFLAGS and CXXFLAGS to have flex 2.6 working
   ./bootstrap.sh -e -t && cd build  && cmake 
-DCMAKE_BUILD_TYPE=Release -DCI_BUILD=ON -DCMAKE_C_FLAGS="${CPPFLAGS} 
${CFLAGS}" -DCMAKE_CXX_FLAGS="${CPPFLAGS} ${CXXFLAGS}" 
-DENABLE_PYTHON_SCRIPTING=ON -DENABLE_LUA_SCRIPTING=ON -DENABLE_SQL=ON 
-DUSE_REAL_ODBC_TEST_DRIVER=ON -DENABLE_AZURE=ON -DENABLE_GCP=ON 
-DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_RULE_MESSAGES=OFF -DSTRICT_GSL_CHECKS=AUDIT 
-DFAIL_ON_WARNINGS=ON .. && cmake --build . --parallel 4
   - name: test
-run: cd build && make test ARGS="--timeout 300 -j4 --output-on-failure"
+id: test
+run: |
+  ulimit -c 1024000

Review Comment:
   Sorry my wording was bad. The bash is the default shell for all non-Windows 
systems, MacOS included. It should be handled the same way as Linux.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1511: MINIFICPP-1716 Recover core dumps from CI

2023-03-21 Thread via GitHub 


lordgamez commented on code in PR #1511:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1511#discussion_r1143708215


##
.github/workflows/ci.yml:
##
@@ -39,9 +39,26 @@ jobs:
   # CPPFLAGS are not recognized by cmake, so we have to force them to 
CFLAGS and CXXFLAGS to have flex 2.6 working
   ./bootstrap.sh -e -t && cd build  && cmake 
-DCMAKE_BUILD_TYPE=Release -DCI_BUILD=ON -DCMAKE_C_FLAGS="${CPPFLAGS} 
${CFLAGS}" -DCMAKE_CXX_FLAGS="${CPPFLAGS} ${CXXFLAGS}" 
-DENABLE_PYTHON_SCRIPTING=ON -DENABLE_LUA_SCRIPTING=ON -DENABLE_SQL=ON 
-DUSE_REAL_ODBC_TEST_DRIVER=ON -DENABLE_AZURE=ON -DENABLE_GCP=ON 
-DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_RULE_MESSAGES=OFF -DSTRICT_GSL_CHECKS=AUDIT 
-DFAIL_ON_WARNINGS=ON .. && cmake --build . --parallel 4
   - name: test
-run: cd build && make test ARGS="--timeout 300 -j4 --output-on-failure"
+id: test
+run: |
+  ulimit -c 1024000

Review Comment:
   On github actions the shell defaults to bash on Linux systems, so it should 
use 1024 byte increments. I clarified the size and changed it to 1GiB in 
1c5e45eb79f07cd70c9509ea23e2ff063f122ea3



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1511: MINIFICPP-1716 Recover core dumps from CI

2023-03-10 Thread via GitHub 


lordgamez commented on code in PR #1511:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1511#discussion_r1132086541


##
.github/workflows/ci.yml:
##
@@ -196,13 +247,36 @@ jobs:
   - id: build
 run: |
   if [ -d ~/.ccache ]; then mv ~/.ccache .; fi
-  mkdir build && cd build && cmake -DUSE_SHARED_LIBS=ON -DCI_BUILD=ON 
-DSTRICT_GSL_CHECKS=AUDIT -DFAIL_ON_WARNINGS=ON -DENABLE_AWS=ON 
-DENABLE_AZURE=ON \
+  mkdir build && cd build && cmake -DUSE_SHARED_LIBS=ON -DCI_BUILD=ON 
-DCMAKE_BUILD_TYPE=Release -DSTRICT_GSL_CHECKS=AUDIT -DFAIL_ON_WARNINGS=ON 
-DENABLE_AWS=ON -DENABLE_AZURE=ON \

Review Comment:
   Added comment in 9b27a6128fc9df37a194857c7d86d037f6c2b137



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1511: MINIFICPP-1716 Recover core dumps from CI

2023-03-08 Thread via GitHub 


lordgamez commented on code in PR #1511:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1511#discussion_r1129199398


##
.github/workflows/ci.yml:
##
@@ -37,11 +37,28 @@ jobs:
   export LDFLAGS="-L/usr/local/opt/flex/lib"
   export CPPFLAGS="-I/usr/local/opt/flex/include"
   # CPPFLAGS are not recognized by cmake, so we have to force them to 
CFLAGS and CXXFLAGS to have flex 2.6 working
-  ./bootstrap.sh -e -t && cd build  && cmake 
-DCMAKE_BUILD_TYPE=Release -DCI_BUILD=ON -DCMAKE_C_FLAGS="${CPPFLAGS} 
${CFLAGS}" -DCMAKE_CXX_FLAGS="${CPPFLAGS} ${CXXFLAGS}" -DENABLE_SCRIPTING=ON 
-DENABLE_LUA_SCRIPTING=ON -DENABLE_SQL=ON -DUSE_REAL_ODBC_TEST_DRIVER=ON 
-DENABLE_AZURE=ON -DENABLE_GCP=ON -DCMAKE_VERBOSE_MAKEFILE=ON 
-DCMAKE_RULE_MESSAGES=OFF -DSTRICT_GSL_CHECKS=AUDIT -DFAIL_ON_WARNINGS=ON .. && 
cmake --build . --parallel 4
+  ./bootstrap.sh -e -t && cd build  && cmake 
-DCMAKE_BUILD_TYPE=RelWithDebInfo -DCI_BUILD=ON -DCMAKE_C_FLAGS="${CPPFLAGS} 
${CFLAGS}" -DCMAKE_CXX_FLAGS="${CPPFLAGS} ${CXXFLAGS}" -DENABLE_SCRIPTING=ON 
-DENABLE_LUA_SCRIPTING=ON -DENABLE_SQL=ON -DUSE_REAL_ODBC_TEST_DRIVER=ON 
-DENABLE_AZURE=ON -DENABLE_GCP=ON -DCMAKE_VERBOSE_MAKEFILE=ON 
-DCMAKE_RULE_MESSAGES=OFF -DSTRICT_GSL_CHECKS=AUDIT -DFAIL_ON_WARNINGS=ON .. && 
cmake --build . --parallel 4
   - name: test
-run: cd build && make test ARGS="--timeout 300 -j4 --output-on-failure"
+id: test
+run: |
+  ulimit -c unlimited

Review Comment:
   Sorry, I missed that, updated in 388a7f93bdefc2b22874f325d9ad80c32b4b973c



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1511: MINIFICPP-1716 Recover core dumps from CI

2023-03-08 Thread via GitHub 


lordgamez commented on code in PR #1511:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1511#discussion_r1129159524


##
.github/workflows/ci.yml:
##
@@ -37,11 +37,28 @@ jobs:
   export LDFLAGS="-L/usr/local/opt/flex/lib"
   export CPPFLAGS="-I/usr/local/opt/flex/include"
   # CPPFLAGS are not recognized by cmake, so we have to force them to 
CFLAGS and CXXFLAGS to have flex 2.6 working
-  ./bootstrap.sh -e -t && cd build  && cmake 
-DCMAKE_BUILD_TYPE=Release -DCI_BUILD=ON -DCMAKE_C_FLAGS="${CPPFLAGS} 
${CFLAGS}" -DCMAKE_CXX_FLAGS="${CPPFLAGS} ${CXXFLAGS}" -DENABLE_SCRIPTING=ON 
-DENABLE_LUA_SCRIPTING=ON -DENABLE_SQL=ON -DUSE_REAL_ODBC_TEST_DRIVER=ON 
-DENABLE_AZURE=ON -DENABLE_GCP=ON -DCMAKE_VERBOSE_MAKEFILE=ON 
-DCMAKE_RULE_MESSAGES=OFF -DSTRICT_GSL_CHECKS=AUDIT -DFAIL_ON_WARNINGS=ON .. && 
cmake --build . --parallel 4
+  ./bootstrap.sh -e -t && cd build  && cmake 
-DCMAKE_BUILD_TYPE=RelWithDebInfo -DCI_BUILD=ON -DCMAKE_C_FLAGS="${CPPFLAGS} 
${CFLAGS}" -DCMAKE_CXX_FLAGS="${CPPFLAGS} ${CXXFLAGS}" -DENABLE_SCRIPTING=ON 
-DENABLE_LUA_SCRIPTING=ON -DENABLE_SQL=ON -DUSE_REAL_ODBC_TEST_DRIVER=ON 
-DENABLE_AZURE=ON -DENABLE_GCP=ON -DCMAKE_VERBOSE_MAKEFILE=ON 
-DCMAKE_RULE_MESSAGES=OFF -DSTRICT_GSL_CHECKS=AUDIT -DFAIL_ON_WARNINGS=ON .. && 
cmake --build . --parallel 4
   - name: test
-run: cd build && make test ARGS="--timeout 300 -j4 --output-on-failure"
+id: test
+run: |
+  ulimit -c unlimited

Review Comment:
   Updated in 2a4c5f11348085e852fbf418f04038e08e864445



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org