[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1551: MINIFICPP-2091 Add ARM64 support for docker system tests

[via GitHub]

lordgamez commented on code in PR #1551:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1551#discussion_r1173693240


##
docker/test/integration/cluster/containers/OPCUAServerContainer.py:
##
@@ -31,7 +31,7 @@ def deploy(self):
 
 logging.info('Creating and running OPC UA server docker container...')
 self.client.containers.run(
-"lordgamez/open62541:1.3.3",
+"lordgamez/open62541:1.3.5",

Review Comment:
   I'm not sure as it is not an Apache product. I created an 
[issue](https://github.com/open62541/open62541/issues/5082) a while back to 
publish the open62541 for the new releases, but so far it has not been done yet.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1551: MINIFICPP-2091 Add ARM64 support for docker system tests

[via GitHub]

lordgamez commented on code in PR #1551:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1551#discussion_r1165618648


##
docker/test/integration/resources/kafka_broker/conf/server.properties:
##
@@ -28,15 +28,15 @@ broker.id=0
 # listeners = listener_name://host_name:port
 #   EXAMPLE:
 # listeners = PLAINTEXT://your.host.name:9092
-#listeners=PLAINTEXT://:9092
+listeners=PLAINTEXT://kafka-broker:9092,SSL://kafka-broker:9093,SASL_PLAINTEXT://kafka-broker:9094,SASL_SSL://kafka-broker:9095,SSL_HOST://0.0.0.0:29093,PLAINTEXT_HOST://0.0.0.0:29092,SASL_PLAINTEXT_HOST://0.0.0.0:29094,SASL_SSL_HOST://0.0.0.0:29095
 
 # Hostname and port the broker will advertise to producers and consumers. If 
not set,
 # it uses the value for "listeners" if configured.  Otherwise, it will use the 
value
 # returned from java.net.InetAddress.getCanonicalHostName().
-#advertised.listeners=PLAINTEXT://your.host.name:9092
+advertised.listeners=PLAINTEXT://kafka-broker:9092,PLAINTEXT_HOST://localhost:29092,SSL://kafka-broker:9093,SSL_HOST://localhost:29093,SASL_PLAINTEXT://kafka-broker:9094,SASL_PLAINTEXT_HOST://localhost:29094,SASL_SSL://kafka-broker:9095,SASL_SSL_HOST://localhost:29095

Review Comment:
   The order doesn't matter, it's better to have a consistent order for all 
properties, updated in 80b1ea36d601632083e4a8b16b5731e8495a668b



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org