[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #1511: MINIFICPP-1716 Recover core dumps from CI

2023-03-21 Thread via GitHub


lordgamez commented on PR #1511:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1511#issuecomment-1477619203

   For some reason I'm not sure of the GCC build cannot utilize ccache in 
github actions if built with RelWithDebInfo. Because of this I kept 
RelWithDebInfo only with the clang build, so we can keep the low build times 
and minimize the cache storage use as well. (Even though Apple clang is a bit 
different from the Ubuntu clang build, the build issues are usually the same 
with both so I kept MacOS build with Release build type.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #1511: MINIFICPP-1716 Recover core dumps from CI

2023-02-16 Thread via GitHub


lordgamez commented on PR #1511:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1511#issuecomment-1432842782

   One thing to consider is that in case of crashing in macos, ubuntu and 
ubuntu-clang builds we can pinpoint the line numbers from the crashdump with 
the RelWithDebInfo build type, but we also use 4 times the cache size of the 
Release build which will result in more cache misses in the future. Is it worth 
to have the debuginfo in case of a crash for slower builds in the future?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org