szaszm opened a new pull request, #1654:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1654
- Enable MQTT by default in the Windows MSI
- Change all instances of "OS X" and "Mac OS X" to "macOS", to be consistent
with Apple's current spelling
- Update the extension list in the README bootstrap example to reflect
enabled by default extensions
- Remove abandoned bootstrap.py
- Update bootstrap.sh to treat recently enabled by default extensions as such
- Changed win_build_vs.bat CLI switches for enabled by default extensions
from an enable switch to an optional disable switch
- Renamed win_build_vs.bat internal variables to a more consistent naming
scheme
I didn't do any in-depth refactoring, as it would be wasted effort with the
upcoming Python bootstrap rewrite.
--------
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI
results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
