[GitHub] nifi-minifi-cpp issue #104: MINIFI-296 - Configurable logging, spdlog 0.13.0
Github user brosander commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/104 removed atomic_load, atomic_store as they are problematic w/ gcc 4.8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #104: MINIFI-296 - Configurable logging, spdlog 0.13.0
Github user brosander commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/104 rebased pr, fixed http get integration tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #104: MINIFI-296 - Configurable logging, spdlog 0.13.0
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/104 reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #104: MINIFI-296 - Configurable logging, spdlog 0.13.0
Github user brosander commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/104 @phrocker I've added atomic load and store to the logger and loggerimpl classes and a pattern option to minifi-log.properties along with some alternative patterns and a link to the spdlog wiki --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #104: MINIFI-296 - Configurable logging, spdlog 0.13.0
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/104 @brosander yeah I think an atomic would solve the problem. yeah, I think the pattern would be cool. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #104: MINIFI-296 - Configurable logging, spdlog 0.13.0
Github user brosander commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/104 @phrocker For your first point about reinitializing logging while a flow is running, is it worth it to switch the delegate reference on the Logger to an atomic? Second point I think should be fairly easily addressable with a format pattern in the logger config. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #104: MINIFI-296 - Configurable logging, spdlog 0.13.0
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/104 This is good stuff. I'm taking a look General comments before I dive in. Did we lose the ability to change the logger format real time? If there was an issue in production and we had to change the logger to a null appender, restarting may not always be possible, whereas sending a shared object through a p2p c2 protocol would allow us to dynamically load and change loggers without impacting the implementation, for example ( kind of a contrived example) Additionally, I Noticed that my logs rolled much more frequently because we have an additional 52 bytes per line in some cases. Is there a way to limit that? It slowed my runs down because there was much more memory allocated by spdlog log statements when threading was high and I tested with trace. Even to the class name would be useful. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
