[GitHub] nifi-minifi-cpp issue #119: MINIFI-70: enhance site2site port negotiation

2017-07-20 Thread phrocker
Github user phrocker commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/119
  
@benqiu2016 I'll get this merged shortly, thanks. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi-minifi-cpp issue #119: MINIFI-70: enhance site2site port negotiation

2017-07-19 Thread benqiu2016
Github user benqiu2016 commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/119
  
@phrocker it is passed now after i retrigger the same.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi-minifi-cpp issue #119: MINIFI-70: enhance site2site port negotiation

2017-07-19 Thread kevdoran
Github user kevdoran commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/119
  
FWIW the tests pass on my Mac as well: MacOS 10.12.5, AppleClang 
8.1.0.8020042


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi-minifi-cpp issue #119: MINIFI-70: enhance site2site port negotiation

2017-07-19 Thread benqiu2016
Github user benqiu2016 commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/119
  
@phrocker it is run OK in my MAC. run OK in Xcode 7.3 and fail in 8.3 in 
travis.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi-minifi-cpp issue #119: MINIFI-70: enhance site2site port negotiation

2017-07-19 Thread phrocker
Github user phrocker commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/119
  
Hi Bin I think this is ready to merge; however, I saw a test failure in 
Travis. Any idea what caused this? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---