[GitHub] nifi-minifi-cpp issue #295: MINFICPP-403: Flow Meta tagging
Github user minifirocks commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/295
@phrocker so if that's the case, we can remove the below meta info when the
meta info container was constructed and just provide the framework, if user
want to use that, they can create their own meta info and add this to the meta
info container. **we provide a framework to let them add their own meta info
into the flow file for mutable meta info.**
: config_(configure) {
+// add version, serial number as default meta info
+std::unique_ptr version = std::unique_ptr <
core::MetaInfo > (new VersionMetaInfo());
+addMetaInfo(std::move(version));
+std::string serial_number;
+config_->get("device.id", serial_number);
+state::metrics::Device device;
+if (serial_number.empty()) {
+ // we did not config serial number, use the mac address
+ serial_number = device.device_id_;
+}
+std::unique_ptr serial_number_meta_info =
std::unique_ptr < core::MetaInfo >(new MetaInfo("device.id", serial_number));
+addMetaInfo(std::move(serial_number_meta_info));
+std::unique_ptr hostname_meta_info = std::unique_ptr
< core::MetaInfo >(new MetaInfo("hostname", device.canonical_hostname_));
+addMetaInfo(std::move(hostname_meta_info));
---
[GitHub] nifi-minifi-cpp issue #295: MINFICPP-403: Flow Meta tagging
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/295 @minifirocks per your comment twelve days ago you mentioned that you didn't want to use a processor because you're putting this on every flow file. That's pretty reasonable, but why do we need to use the attributes? This is something that's intended for immutable information, right? could we not have a static strings within the flow file for just the flow version that are serialized along with attributes? If we do that we can let the other information be sent via C2 and correlated via provenance. I don't see the need to include meta information on every flow file for information that's immutable. Mutable information is better sent in the flow file because those immutable data points can be correlated when evaluating flow files from a given source. ---
[GitHub] nifi-minifi-cpp issue #295: MINFICPP-403: Flow Meta tagging
Github user minifirocks commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/295 @phrocker please let me know whether you have more comments. Thanks. ---
[GitHub] nifi-minifi-cpp issue #295: MINFICPP-403: Flow Meta tagging
Github user minifirocks commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/295 @phrocker please review change shared_ptr to unique ptr use agent.version and flow.version for meta info ---
[GitHub] nifi-minifi-cpp issue #295: MINFICPP-403: Flow Meta tagging
Github user minifirocks commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/295 @phrocker the reason that i do not want to use processor is that meta info below to flow which is generated by the any processor. we provide a framework let user to write their own meta info and add to the container. for example, they can add vendor specified meta info. as for the shared ptr, i can change to unique ptr. i pick share ptr because it make it more flexible in case it need to be used somewhere besides the container. ---
[GitHub] nifi-minifi-cpp issue #295: MINFICPP-403: Flow Meta tagging
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/295 I've been thinking more about this @minifirocks . I'm curious about the inception of this idea. I see that there is coupling amongst components that probably don't have a need to know for the metadata. In my opinion if you are putting the information in the attributes then it is potentially removable anyway, so why not use a Processor? If it's an immutable structure within the flow file then it makes sense to do it at construction -- and not in the attributes. Further, any reason to use shared pointers for much of that meta information? Ownership seems like it would be well defined and thus should be coupled to the lifetime of that object. Move semantics (IMO) make more sense with that type of component lifetime, further compounded by the fact that they could be immutable. ---
[GitHub] nifi-minifi-cpp issue #295: MINFICPP-403: Flow Meta tagging
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/295 @minifirocks that script is used with cmake to provide that information in a codified, statically defined way, to the code base. It's built at compile time and provides the agent with the information. Instead of using pragma definitions to pass the information it is statically defined. Additionally, the information this ticket is supposed to provide is flow information not agent information, correct? ---
[GitHub] nifi-minifi-cpp issue #295: MINFICPP-403: Flow Meta tagging
Github user minifirocks commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/295 @phrocker Thanks for the review. the PR is not only for version, it provide a flexible framework to add other meta info also. also in the cmake file, we already specify major/minor/patch version, why we need another generateVersion.sh. ---
[GitHub] nifi-minifi-cpp issue #295: MINFICPP-403: Flow Meta tagging
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/295
`#ifndef AGENT_BUILD_H
#define AGENT_BUILD_H
#include
namespace org {
namespace apache {
namespace nifi {
namespace minifi {
class AgentBuild {
public:
static constexpr const char* VERSION = "0.5.0";
static constexpr const char* BUILD_IDENTIFIER = "";
static constexpr const char* BUILD_REV =
"b68d22ba55cfea069cbdbf7931e2b234d86b1f12";
static constexpr const char* BUILD_DATE = "1522951804";
static constexpr const char* COMPILER =
"/Library/Developer/CommandLineTools/usr/bin/c++";
static constexpr const char* COMPILER_VERSION = "9.0.0.938";
static constexpr const char* COMPILER_FLAGS = " -std=c++11 -Wall";
static std::vector getExtensions() {
static std::vector extensions;
if (extensions.empty()){
extensions.push_back("minifi-expression-language-extensions");
extensions.push_back("minifi-http-curl");
extensions.push_back("minifi-civet-extensions");
extensions.push_back("minifi-rocksdb-repos");
extensions.push_back("minifi-archive-extensions");
extensions.push_back("minifi-gps");
extensions.push_back("minifi-mqtt-extensions");
extensions.push_back("minifi-pcap");
extensions.push_back("minifi-rdkafka-extensions");
extensions.push_back("minifi-script-extensions");
extensions.push_back("minifi-usb-camera-extensions");
}
return extensions;
}
};
} /* namespace minifi */
} /* namespace nifi */
} /* namespace apache */
} /* namespace org */
#endif /* AGENT_BUILD_H */
`
is an example.
---
