[GitHub] nifi-minifi-cpp issue #315: MINIFICPP-472 Added date formatting EL functions
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/315 @achristianson ah, fair point. otherwise looks good to go. thanks for the fixes! ---
[GitHub] nifi-minifi-cpp issue #315: MINIFICPP-472 Added date formatting EL functions
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/315 @apiri I think that might be more of a container issue vs. a build issue. The date lib interacts with the system zoneinfo db, so I think trouble with that is why it is raising a runtime exception during the test. ---
[GitHub] nifi-minifi-cpp issue #315: MINIFICPP-472 Added date formatting EL functions
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/315
Looks like we have build issues with that change. I attempted building in
an Ubuntu 17.10 container:
```
ExpressionLanguageTests is a Catch v1.6.1 host application.
Run with -? for options
---
Parse Date
---
/root/nifi-minifi-cpp/libminifi/test/expression-language-tests/ExpressionLanguageTests.cpp:1216
...
/root/nifi-minifi-cpp/libminifi/test/expression-language-tests/ExpressionLanguageTests.cpp:1221:
FAILED:
REQUIRE( "139884120" == expr({flow_file_a}).asString() )
due to unexpected exception with message:
discover_tz_dir failed to find zoneinfo
---
Format Date
---
/root/nifi-minifi-cpp/libminifi/test/expression-language-tests/ExpressionLanguageTests.cpp:1224
...
/root/nifi-minifi-cpp/libminifi/test/expression-language-tests/ExpressionLanguageTests.cpp:1229:
FAILED:
REQUIRE( "03-14-2014" == expr({flow_file_a}).asString() )
due to unexpected exception with message:
discover_tz_dir failed to find zoneinfo
---
Reformat Date
---
/root/nifi-minifi-cpp/libminifi/test/expression-language-tests/ExpressionLanguageTests.cpp:1232
...
/root/nifi-minifi-cpp/libminifi/test/expression-language-tests/ExpressionLanguageTests.cpp:1237:
FAILED:
REQUIRE( "03-13-2014" == expr({flow_file_a}).asString() )
due to unexpected exception with message:
discover_tz_dir failed to find zoneinfo
---
Now Date
---
/root/nifi-minifi-cpp/libminifi/test/expression-language-tests/ExpressionLanguageTests.cpp:1240
...
/root/nifi-minifi-cpp/libminifi/test/expression-language-tests/ExpressionLanguageTests.cpp:1249:
FAILED:
REQUIRE( (lt.tm_year + 1900) == expr({flow_file_a}).asUnsignedLong() )
due to unexpected exception with message:
discover_tz_dir failed to find zoneinfo
```
---
[GitHub] nifi-minifi-cpp issue #315: MINIFICPP-472 Added date formatting EL functions
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/315 @apiri done. ---
[GitHub] nifi-minifi-cpp issue #315: MINIFICPP-472 Added date formatting EL functions
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/315 @achristianson Looks like we need to define the date macro. We should probably also clear out the test elements from the thirdparty source. ---
[GitHub] nifi-minifi-cpp issue #315: MINIFICPP-472 Added date formatting EL functions
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/315 @achristianson will scope out in a bit ---
[GitHub] nifi-minifi-cpp issue #315: MINIFICPP-472 Added date formatting EL functions
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/315 @apiri looks like travis issue is fixed. Did you see any other issues? ---
[GitHub] nifi-minifi-cpp issue #315: MINIFICPP-472 Added date formatting EL functions
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/315 @apiri Confirmed compiler version issue, from Howard Hinnant, author of date: "I'm not positive to tell you the truth, but based on this bug report: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60396 my best guess is gcc-5 and forward, at least for date::parse. The parse function is implemented in terms of the C++11 std::time_get::get() function(s) proposed by this 2007 paper: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2321.html. There is no workaround, except to manually implement your own parsing. Sorry." https://gitter.im/HowardHinnant/date/archives/2016/08/31 Will add a version restriction. ---
[GitHub] nifi-minifi-cpp issue #315: MINIFICPP-472 Added date formatting EL functions
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/315 Ah, seems to be in the 3rd party date lib. We might need to disable these date fns when an old compiler is in use (similar to how we disable regex). The lib should support C++11 though, so will look into it a bit more before making the call. ---
[GitHub] nifi-minifi-cpp issue #315: MINIFICPP-472 Added date formatting EL functions
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/315 Looks like there are still build issues: https://api.travis-ci.org/v3/job/379278498/log.txt https://travis-ci.org/apiri/nifi-minifi-cpp/builds/379278497 ---
[GitHub] nifi-minifi-cpp issue #315: MINIFICPP-472 Added date formatting EL functions
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/315 Taking a look. ---
[GitHub] nifi-minifi-cpp issue #315: MINIFICPP-472 Added date formatting EL functions
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/315 @achristianson Started reviewing. Build failed on my local envs and it looks like Travis is reproducing the same. Also seems to be present for #325. Could you fix those up and rebase please? ---
