[GitHub] nifi-minifi-cpp issue #360: MINIFICPP-427 - add PublishKafka headers support

2018-07-30 Thread phrocker 
Github user phrocker commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/360
  
@dtrodrigues thanks for pointing out the readme update for bustache. I'll 
add that via MINIFICPP-582 and merge this. 


---

[GitHub] nifi-minifi-cpp issue #360: MINIFICPP-427 - add PublishKafka headers support

2018-07-29 Thread phrocker 
Github user phrocker commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/360
  
@dtrodrigues Cool, I'll take a look at the changes tomorrow. I'll probably 
just make a follow on ticket for the bootstrap and merge if everything else 
looks good. Thanks


---

[GitHub] nifi-minifi-cpp issue #360: MINIFICPP-427 - add PublishKafka headers support

2018-07-29 Thread dtrodrigues 
Github user dtrodrigues commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/360
  
I've pushed a commit which updates the README regarding the GCC version 
required and refactored the extension code slightly. I'm not sure of the best 
way to incorporate the GCC version requirement into the bootstrap script -- I'm 
not seeing how it enforces the appropriate compiler versions for Lua/bustache 
currently.


---