[GitHub] nifi-minifi-cpp pull request #118: MINIFI-311 Move to alpine base for docker...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi-minifi-cpp/pull/118


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi-cpp pull request #118: MINIFI-311 Move to alpine base for docker...

[apiri]

Github user apiri commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/118#discussion_r129909967
  
--- Diff: thirdparty/spdlog-20170710/tests/CMakeLists.txt ---
@@ -0,0 +1,19 @@
+#
--- End diff --

Should remove the tests subdirectory and skip this part of the build for 
the lib


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi-cpp pull request #118: MINIFI-311 Move to alpine base for docker...

[apiri]

Github user apiri commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/118#discussion_r129904782
  
--- Diff: thirdparty/spdlog-20170710/bench/boost-bench-mt.cpp ---
@@ -0,0 +1,84 @@
+//
--- End diff --

Should remove the entirety of the bench subdirectory.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi-cpp pull request #118: MINIFI-311 Move to alpine base for docker...

[apiri]

Github user apiri commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/118#discussion_r129905012
  
--- Diff: thirdparty/spdlog-20170710/example/CMakeLists.txt ---
@@ -0,0 +1,49 @@
+# 
*/
--- End diff --

Should remove the entirety of the example directory


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi-cpp pull request #118: MINIFI-311 Move to alpine base for docker...

[apiri]

Github user apiri commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/118#discussion_r129904610
  
--- Diff: thirdparty/spdlog-20170710/.travis.yml ---
@@ -0,0 +1,90 @@
+# Adapted from various sources, including:
--- End diff --

We should remove this from the source inclusion.  Anything beyond the 
actual source should get stripped out to minimize LICENSE/NOTICE concerns.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi-cpp pull request #118: MINIFI-311 Move to alpine base for docker...

[achristianson]

GitHub user achristianson opened a pull request:

https://github.com/apache/nifi-minifi-cpp/pull/118

MINIFI-311 Move to alpine base for docker image.

This change takes the 1.5G ubuntu minifi image and reduces it to a 39MB 
image by using a multi-stage alpine build.

MINIFI-311 ported dockerfile to alpine
MINIFI-311 allow warnings on Linux for compatibility with Alpine
MINIFI-311 fixed spdlog path in BuildTests cmake file
MINIFI-349 moved to multi-stage docker build

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFI-311

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi-cpp/pull/118.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #118


commit 95e58d0fba850f9643bf13774863124fc4b0659c
Author: Andrew Christianson 
Date:   2017-07-11T16:05:33Z

MINIFI-311 upgraded spdlog to snapshot of master
MINIFI-311 ported dockerfile to alpine
MINIFI-311 allow warnings on Linux for compatibility with Alpine
MINIFI-311 fixed spdlog path in BuildTests cmake file
MINIFI-349 moved to multi-stage docker build




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---