[GitHub] nifi-minifi-cpp pull request #313: MINIFICPP-403: Add version into flow attr...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi-minifi-cpp/pull/313


---

[GitHub] nifi-minifi-cpp pull request #313: MINIFICPP-403: Add version into flow attr...

[minifirocks]

Github user minifirocks commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/313#discussion_r185257853
  
--- Diff: libminifi/test/resources/TestHTTPGet.yml ---
@@ -19,6 +19,7 @@
 Flow Controller:
 name: MiNiFi Flow
 id: 2438e3c8-015a-1000-79ca-83af40ec1990
+version: 1
--- End diff --

@phrocker that's flow config yml version, i thought it refer to the the 
flow version. when you update the YML file, flow version change also


---

[GitHub] nifi-minifi-cpp pull request #313: MINIFICPP-403: Add version into flow attr...

[phrocker]

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/313#discussion_r185256992
  
--- Diff: libminifi/test/resources/TestHTTPGet.yml ---
@@ -19,6 +19,7 @@
 Flow Controller:
 name: MiNiFi Flow
 id: 2438e3c8-015a-1000-79ca-83af40ec1990
+version: 1
--- End diff --

Isn't this the flow config yaml version and not the flow version ? Is the 
version above intended to be the config yaml version or the flow version?


---

[GitHub] nifi-minifi-cpp pull request #313: MINIFICPP-403: Add version into flow attr...

[minifirocks]

GitHub user minifirocks opened a pull request:

https://github.com/apache/nifi-minifi-cpp/pull/313

MINIFICPP-403: Add version into flow attributes

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
 in the commit message?

- [ ] Does your PR title start with MINIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/minifirocks/nifi-minifi-cpp 
add_version_to_flow

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi-cpp/pull/313.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #313






---