[GitHub] nifi-registry issue #117: NIFIREG-160 Implement a hook provider

2018-05-15 Thread pvillard31
Github user pvillard31 commented on the issue:

https://github.com/apache/nifi-registry/pull/117
  
Merged to master, thanks!


---


[GitHub] nifi-registry issue #117: NIFIREG-160 Implement a hook provider

2018-05-15 Thread bbende
Github user bbende commented on the issue:

https://github.com/apache/nifi-registry/pull/117
  
@pvillard31 thanks for the review, i'm fine with you doing the minor 
cleanup on merge, thanks!


---


[GitHub] nifi-registry issue #117: NIFIREG-160 Implement a hook provider

2018-05-15 Thread pvillard31
Github user pvillard31 commented on the issue:

https://github.com/apache/nifi-registry/pull/117
  
@bbende  I just did some tests with various possible configurations and 
different hooks, it's working as expected. The dedicated log file is really 
great and useful. Let me know if you want to do something regarding my comments 
or I can take care of it while merging if you are OK with it.


---


[GitHub] nifi-registry issue #117: NIFIREG-160 Implement a hook provider

2018-05-15 Thread pvillard31
Github user pvillard31 commented on the issue:

https://github.com/apache/nifi-registry/pull/117
  
Hi @bbende - I should be able to review and test shortly, will let you 
know. Thanks again for this PR!


---


[GitHub] nifi-registry issue #117: NIFIREG-160 Implement a hook provider

2018-05-14 Thread bbende
Github user bbende commented on the issue:

https://github.com/apache/nifi-registry/pull/117
  
@pvillard31 this should be good to go pending any review feedback, let me 
know if you have any cycles to take a look, thanks


---


[GitHub] nifi-registry issue #117: NIFIREG-160 Implement a hook provider

2018-05-09 Thread bbende
Github user bbende commented on the issue:

https://github.com/apache/nifi-registry/pull/117
  
For an easy way to test this you can turn uncomment the 
LoggingEventHookProvider in providers.xml and then use the registry as normal 
to create buckets and save flows from NiFi, then tail or inspect 
logs/nifi-registry-event.log


---