[GitHub] nifi-registry issue #142: NIFIREG-200 Update dependencies

2018-09-21 Thread bbende
Github user bbende commented on the issue:

https://github.com/apache/nifi-registry/pull/142
  
This looks good and I'll merge to master.

Something I noticed while reviewing this (not a result of anything in this 
PR), is that the nifi-registry-extensions modules are impacted by the top-level 
dependency management, which could have unforeseen consequences.

I created this JIRA with further information: 
https://issues.apache.org/jira/browse/NIFIREG-201


---


[GitHub] nifi-registry issue #142: NIFIREG-200 Update dependencies

2018-09-21 Thread bbende
Github user bbende commented on the issue:

https://github.com/apache/nifi-registry/pull/142
  
Reviewing..


---


[GitHub] nifi-registry issue #142: NIFIREG-200 Update dependencies

2018-09-20 Thread kevdoran
Github user kevdoran commented on the issue:

https://github.com/apache/nifi-registry/pull/142
  
Good catch @alopresto. I was simply trying to pin a single version of Guava 
as we were using 18.0 but 17.0 was being pulled in transitively. But I don't 
see any reason not to pin version 26.0, so I updated my branch to use that. 
Compilation and runtime seem unaffected. Thanks!


---


[GitHub] nifi-registry issue #142: NIFIREG-200 Update dependencies

2018-09-20 Thread alopresto
Github user alopresto commented on the issue:

https://github.com/apache/nifi-registry/pull/142
  
@kevdoran any reason you decided on 18.0 for guava? Looks like the most 
recent release is 26.0 [Guava](https://github.com/google/guava). 


---


[GitHub] nifi-registry issue #142: NIFIREG-200 Update dependencies

2018-09-20 Thread kevdoran
Github user kevdoran commented on the issue:

https://github.com/apache/nifi-registry/pull/142
  
@bbende if you could review this when you get a chance that would be 
appreciated


---