[GitHub] nifi issue #1002: NIFI-2684 - Change AbstractConfigurableComponent to use di...

2016-11-15 Thread mattyb149
Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/1002
  
Per a discussion with @trixpan, I offered to make the final change and add 
the commit when merging this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #1002: NIFI-2684 - Change AbstractConfigurableComponent to use di...

2016-10-13 Thread trixpan
Github user trixpan commented on the issue:

https://github.com/apache/nifi/pull/1002
  
@joewitt hopefully last commit addresses your feedback. Mind having another 
look?

Cheers


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #1002: NIFI-2684 - Change AbstractConfigurableComponent to use di...

2016-09-11 Thread trixpan
Github user trixpan commented on the issue:

https://github.com/apache/nifi/pull/1002
  
@joewitt this commit is quite small (intent is just aesthetics / UX) but 
ventures into waters I don't usually sail... Would you mind having a look?

I thank you in advance


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---