[GitHub] nifi issue #1018: NIFI-1662 adding Expression Language decimal support
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1018 +1 LGTM, great addition here, thanks! Merging to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1018: NIFI-1662 adding Expression Language decimal support
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1018 > (who uses Hex literals for floating point?!), I do! Like... All the time! But I also joke sometimes... :smiley: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1018: NIFI-1662 adding Expression Language decimal support
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1018 @mattyb149 just pushed out a new commit along with yours. I added proper support for literal decimals in the UI as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1018: NIFI-1662 adding Expression Language decimal support
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1018 @mattyb149 this is awesome! I was having bit of trouble trying with the grammar due to not knowing much about ANTLR. I'm gonna add your commit to my branch, test it a bit and then add it to the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1018: NIFI-1662 adding Expression Language decimal support
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1018 I'm a big ANTLR fan :) so I tried adding decimal literals to the grammar, feel free to take a look and use whatever you like: https://github.com/mattyb149/nifi/commit/9ed3fb4f17b0ec64fbe9d861ff255750c3ec7e5a --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1018: NIFI-1662 adding Expression Language decimal support
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/1018
@mattyb149, I agree with adding it to the lexer as a subset. I thought
through it a bit more and is someone passes "toLiteral('1.1')" they should
expect they would get a string with the value "1.1".
I'll do some research on the best way to parse double/floating points via
Antlr and post a new commit.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1018: NIFI-1662 adding Expression Language decimal support
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1018 I like the idea of a subset, we can probably cover 90% of the cases people have for floating-point literals (who uses Hex literals for floating point?!), but it might warrant a discussion with the community. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
