[GitHub] nifi issue #1136: [NIFI-2900] fixes timestamps to be ISO 8601 compliant, as ...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1136 Thanks @simplesteph! This has been merged to master (without the changes to the TimeAdapter). I've created a JIRA [1] to revisit the entirety of the Rest Api with regards to the OpenApi spec when possible. [1] https://issues.apache.org/jira/browse/NIFI-2978 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1136: [NIFI-2900] fixes timestamps to be ISO 8601 compliant, as ...
Github user simplesteph commented on the issue: https://github.com/apache/nifi/pull/1136 hi @mcgilman , pain commit but it should be good. the resulting `swagger.json` doesn't have any datetime, which makes the api compliant in that regard. Not sure when 2.0 is planned, and not sure how you track todos against it, but converting these fields back to compliant datetime is a must for the next version of the api --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1136: [NIFI-2900] fixes timestamps to be ISO 8601 compliant, as ...
Github user simplesteph commented on the issue: https://github.com/apache/nifi/pull/1136 Sorry I haven't had the time to work on it just yet... Agree with all the above --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1136: [NIFI-2900] fixes timestamps to be ISO 8601 compliant, as ...
Github user mike42 commented on the issue: https://github.com/apache/nifi/pull/1136 @mcgilman- I would also like to see the REST API change in the next major release. Date localisation should be moved to the front-end, as only the browser knows the user's locale and timezone. Noting your comments above, would you be open to reviewing a pull request which corrects the API to use ISO timestamps, and also introduces `moment.js` in the front end to display localised timestamps? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1136: [NIFI-2900] fixes timestamps to be ISO 8601 compliant, as ...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1136 Hey sorry, I was traveling yesterday. I don't see your most recent changes. Can you double check that you've pushed them? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1136: [NIFI-2900] fixes timestamps to be ISO 8601 compliant, as ...
Github user simplesteph commented on the issue: https://github.com/apache/nifi/pull/1136 I think then we need to add `dataType = "string"` in the annotation to every field `DateTime` that uses any `TimeAdapter` or `DateTimeAdapter`. Hopefully this way the format won't be shown as "date-time". Somehow my maven is acting up and I can't test it... Let me know your thoughts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1136: [NIFI-2900] fixes timestamps to be ISO 8601 compliant, as ...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1136 NiFi follows the semantic versioning guidelines. What your suggesting is changing the meaning of those fields. They are strings that are meant to be human-readable (one with the time and the other with the date and time). If we change them, we could be affecting any existing clients of that API that expect them to be human-readable strings. The clients I'm referring is anyone consuming this API in an existing version of NiFi. As you mentioned, in our case we would need to update the UI (which is a client of this API) to reformat it as necessary. This is not something we would expect others to do in a minor/incremental version change or without somehow versioning the API. As I mentioned earlier, I believe that any field using a JAXB adapter is currently being interpreted incorrectly by Swagger. While it would be nice if Swagger could correctly determine the actual data type (a string in this case and not a date-time) it appears they at least provide a mechanism for setting it explicitly. We should be taking advantage of that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1136: [NIFI-2900] fixes timestamps to be ISO 8601 compliant, as ...
Github user simplesteph commented on the issue: https://github.com/apache/nifi/pull/1136 That could be a solution, but I believe it's a more complicated one than just keeping the date-time annotation and make the API compliant with the OpenAPI specs. If you create a "Time" class then it could work. I looked and it seems that yes, Swagger doesn't take JAXB adapters into account. I'm still wondering if it wouldn't be simpler and better to just keep it as date-time and update the UI to re-format it if need be. Which clients would be broken by this change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
