[GitHub] nifi issue #1142: NIFI-2624 JdbcCommon treats BigDecimals now as Avro Logica...
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1142 Just wanted to share my progress on this. I've add Logical Decimal support as well as Date/Time/Timestamp. As @ToivoAdams pointed out, it's important to make this enhancement work with other part of NiFi and outside of NiFi. We have AvroReader controller service now to consume Avro records for various processors. I've been testing logical types can be ready by AvroReader correctly and it works well so far. I think I'm very close to send a PR. I'll do more testing with databases other than MySQL. My branch is available here if you are interested: https://github.com/ijokarumawak/nifi/commit/1ebb9ee9ac16e7651c3e09c6f4f2b6d33d20e7cb Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1142: NIFI-2624 JdbcCommon treats BigDecimals now as Avro Logica...
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1142 @trixpan Thanks for sharing the comment. @ToivoAdams @joewitt Sorry for not responding, I hadn't watched the JIRA issue and didn't notice this has been updated. I will polish my commit and do more testing then send another PR for NIFI-2624. Probably my PR will be available sometime in the next week. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1142: NIFI-2624 JdbcCommon treats BigDecimals now as Avro Logica...
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1142 Adding @ToivoAdams comment here as his last comment on JIRA did use github's @ mentions instead of JIRAs [~ ] mentions: > @ijokarumawak > > Sorry I didn't have time to look your code. > Your approach looks much better. > My only concern is â do we generate record which conforms to Avro standard? > Can any other consumer (outside NiFi) read our Avro record and get back same BigDecimal? > > @joewitt > Right, letâs try to finish this. > Thanks > Toivo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1142: NIFI-2624 JdbcCommon treats BigDecimals now as Avro Logica...
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/1142 @ijokarumawak @ToivoAdams @trixpan can we reach consensus on next steps here and go for it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1142: NIFI-2624 JdbcCommon treats BigDecimals now as Avro Logica...
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1142 Hi @ToivoAdams @trixpan I've encountered similar issue. So I've researched and tried to use Avro 1.8.1 LogicalTypes, without knowing there's an existing JIRA and PR to solve that, thanks for tackling this! I've modified the code similarly, but used a bit different approach, so I wanted you to look at mine, too. It's available in my [remote branch](https://github.com/ijokarumawak/nifi/commit/dbde98e1b3a7dc9316308170fb4b66b6deeed606). I felt that it can be better if we can opt-in this new conversion, so that existing flow can work with String representation. Also, we might be able to resolve other data types such as Date, using the same mechanism. How do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
