[GitHub] nifi issue #1143: NIFI-2905: Log error stream of ExecuteProcess cmd

2016-10-24 Thread JPercivall
Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/1143
  
@ijokarumawak @alopresto @pvillard31 I am seeing errors in travis related 
to this PR[1]. I am going to re-open the ticket in order to investigate

[1] https://s3.amazonaws.com/archive.travis-ci.org/jobs/170218968/log.txt


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #1143: NIFI-2905: Log error stream of ExecuteProcess cmd

2016-10-18 Thread alopresto
Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1143
  
Built with `contrib-check` and verified all tests pass. I started the 
application, and used an `ExecuteProcess` processor with command `cd` and 
arguments `non-existent-dir`. With `Redirect Error Stream` set to **false** 
(default), the errors appeared as bulletins. With `Redirect Error Stream` set 
to **true**, no bulletins were raised, and the error message was found in the 
resulting flowfile contents. 

+1, merging. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #1143: NIFI-2905: Log error stream of ExecuteProcess cmd

2016-10-18 Thread alopresto
Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1143
  
Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #1143: NIFI-2905: Log error stream of ExecuteProcess cmd

2016-10-17 Thread ijokarumawak
Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/1143
  
@pvillard31 Thanks for catching that, I was able to reproduce that the test 
fails with mvn command. Investigating how to address it. I'll send an updated 
PR once it's get fixed. Thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #1143: NIFI-2905: Log error stream of ExecuteProcess cmd

2016-10-17 Thread pvillard31
Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/1143
  
Hey @ijokarumawak 
One of the unit tests is failing on my side:
Failed tests:
  TestExecuteProcess.testNotRedirectErrorStream:226 If redirect error 
stream is false, the output should be logged as a warning so that user can 
notice on bulletin. expected:<1> but was:<0>

Note: the test is failing while running a maven build, although everything 
is fine in my IDE.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---