[GitHub] nifi issue #1267: NIFI-3091: Ensure that we set the appropriate size on Flow...

2016-11-23 Thread JPercivall
Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/1267
  
For tracking, this PR fixes the bug that was introduced here: 
https://github.com/apache/nifi/commit/aa99cc68224f104ad13396e2102126db6332e5c7#diff-f010d6e495dd9553ac1c60ca175f14d7R2583


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #1267: NIFI-3091: Ensure that we set the appropriate size on Flow...

2016-11-23 Thread JPercivall
Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/1267
  
+1

Visually verified code and did a contrib check build. In standalone and a 3 
node secure cluster I tested a flow which failed beforehand. I also reverted 
the change in "StandardProcessSession" and ran the unit test to see it failed 
as expected. Thanks @markap14 I will merge it in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #1267: NIFI-3091: Ensure that we set the appropriate size on Flow...

2016-11-23 Thread JPercivall
Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/1267
  
Reviewing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #1267: NIFI-3091: Ensure that we set the appropriate size on Flow...

2016-11-23 Thread JPercivall
Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/1267
  
+1

Visually verified code and did a contrib check build. In standalone and a 3 
node secure cluster built up a large queue of flowfiles, stopped the instances 
and removed the flow.xml, restarted the instances and saw it work as expected. 
Thanks @markap14 I will merge it in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---