[GitHub] nifi issue #1480: NIFI-1657 - Configure travis-ci to run mvn verify in jp an...
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1480 ð Thanks a lot @trixpan, I know it has been a real nightmare to get things working with Travis... Will merge ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1480: NIFI-1657 - Configure travis-ci to run mvn verify in jp an...
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1480 @pvillard31 - after a few hundred builds and options build seems to be having as expected: https://travis-ci.org/trixpan/nifi/builds/200568234 when environment is set to en_US or "default", build succeeds while the french build fails as expected. https://travis-ci.org/trixpan/nifi/jobs/200568237#L2899 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1480: NIFI-1657 - Configure travis-ci to run mvn verify in jp an...
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1480 @pvillard31 - this seems to be working now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1480: NIFI-1657 - Configure travis-ci to run mvn verify in jp an...
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1480 by the way, good catch, I had faced this issue before but totally forgot about it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1480: NIFI-1657 - Configure travis-ci to run mvn verify in jp an...
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1480 seems great. will do it and force push soon --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1480: NIFI-1657 - Configure travis-ci to run mvn verify in jp an...
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/1480
@trixpan I just wanted to check before getting this merged but I believe
setting the properties like you did does not change the locale settings for
surefire plugin (unit tests). The fact is I know there are some tests failing
with French locale although the travis build looks OK.
There is at least one in:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/
This is tracked with NIFI-2683.
So I just did some tests:
If I run
mvn clean install -Duser.language=fr -Duser.region=FR
In the above directory, the build is fine.
But if I change the parent pom.xml with what I suggested in the JIRA:
org.apache.maven.plugins
maven-surefire-plugin
2.18
**/*Test.class
**/Test*.class
**/*Spec.class
true
-Xmx1G
-Djava.net.preferIPv4Stack=true -Duser.language=fr -Duser.region=FR
org.apache.maven.surefire
surefire-junit4
2.18
and run
mvn clean install
then I have a test failure:
Failed tests:
StandardHttpResponseMapperSpec.MergeResponses: #responseEntities.size()
HTTP 200 #httpMethod responses for #requestUriPart:122 Condition not satisfied:
IIRC the arguments passed along the maven command are not used by surefire
plugin which uses its own environment to run unit tests.
So here is my proposition, in the parent pom, add an empty property like
this:
1.8
1.8
3.1.0
...
Then, in the plugin configuration, change the argLine with:
-Xmx1G -Djava.net.preferIPv4Stack=true
${maven.surefire.arguments}
This way, there is absolutely no change with the current behavior and the
default locale of the system will remain the one used when building. However
you can now specify the locale to use with:
mvn clean install -Dmaven.surefire.arguments="-Duser.language=fr
-Duser.region=FR"
And I confirm that the test is failing as "expected".
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1480: NIFI-1657 - Configure travis-ci to run mvn verify in jp an...
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1480 @pvillard31 seems good to go. failures were caused by TCP processors --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1480: NIFI-1657 - Configure travis-ci to run mvn verify in jp an...
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1480 Only if you commit to port NiFi to minitel. :rofl: ... Just kidding, done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1480: NIFI-1657 - Configure travis-ci to run mvn verify in jp an...
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1480 I believe we need one more... I know what you are going to say: French people... what a pain ;) 123Â 456 fr_FR 345Â 987,246 fr_FR 123.456 pt_BR 345.987,246 pt_BR 123,456 ja_JP 345,987.246 ja_JP 123,456 en_US 345,987.246 en_US --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1480: NIFI-1657 - Configure travis-ci to run mvn verify in jp an...
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1480 by the way, just in case someone ever wonder the rationale behind the countries: basic English (Java's default env), a Latin and a "Asian" language with no official status at the UN. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1480: NIFI-1657 - Configure travis-ci to run mvn verify in jp an...
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1480 @pvillard31 good catch! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1480: NIFI-1657 - Configure travis-ci to run mvn verify in jp an...
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1480 @pvillard31 I changed the commit a bit so to use envs (I think things should move faster this way) I reckon we should merge and use it to correct residual issues. This second attempt should hopefully create two independent builds (env in travis lingo) so we will still be able to figure out if the issue is widespread or related to locale. what do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1480: NIFI-1657 - Configure travis-ci to run mvn verify in jp an...
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1480 Thanks @trixpan, this will be useful! What do you think: should we get this merged now or wait to fix the tests known to fail with specific locales? (just to avoid a lot of build failures in the meantime) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
