[GitHub] nifi issue #1490: NIFI-3452: Add Wait processor Wait Mode property
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1490 Perfect, ð merging to master, thanks @ijokarumawak --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1490: NIFI-3452: Add Wait processor Wait Mode property
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1490 As a side note, there's Notify processor which is designed to work together with Wait processor. Since there's an existing PR #1466 adding properties to Notify, I didn't touch it by this PR. Please check #1466 for Notify processor update. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1490: NIFI-3452: Add Wait processor Wait Mode property
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1490 Thanks for reviewing, @pvillard31 . I've updated this PR: - Rebased with the latest master, just in case - Added display name and name - Corrected indent (probably this is the minor styling issue..?) Please let me know if there's anything else. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1490: NIFI-3452: Add Wait processor Wait Mode property
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1490 Hi @ijokarumawak, thanks for this improvement, that's really nice. And thanks for the template, it was really useful to review this PR! I just have a minor styling issue and since this processor is not released yet: could you just update the properties to use both ``.name()`` and ``.displayName()``? Otherwise LGTM and I'll merge as soon as you let me know. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1490: NIFI-3452: Add Wait processor Wait Mode property
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1490 @basvank Thanks for confirming the change, that certainly make the review & merge process easier! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1490: NIFI-3452: Add Wait processor Wait Mode property
Github user basvank commented on the issue: https://github.com/apache/nifi/pull/1490 @ijokarumawak I have tested your patch on a single node with 3 the same flows and it does exactly what I expected and required as explained in [my mailing list entry](http://apache-nifi-users-list.2361937.n4.nabble.com/Problem-when-using-backpressure-to-distribute-load-over-nodes-in-a-cluster-tp863p903.html). I am not able to test in the cluster setting at this moment but I see no reason why it wouldn't work there. Thanks for your effort! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1490: NIFI-3452: Add Wait processor Wait Mode property
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1490 Dear reviewer, an example flow template is available here: https://gist.github.com/ijokarumawak/85a3d77297ea94614e9f3f2a9dabca67 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
