[GitHub] nifi issue #1499: NIFI-3455 Large row count paging
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1499 ð merging, thanks @patricker --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1499: NIFI-3455 Large row count paging
Github user patricker commented on the issue: https://github.com/apache/nifi/pull/1499 @pvillard31 Thanks for the review. Ever since the last IntelliJ update my CheckStyle plugin has been acting up. Should all be fixed now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1499: NIFI-3455 Large row count paging
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1499 Hey @patricker, It looks good to me, thanks for the PR. Could you fix the checkstyle violations? [WARNING] src/test/java/org/apache/nifi/processors/standard/TestGenerateTableFetch.java[40:8] (imports) UnusedImports: Unused import - java.sql.JDBCType. [WARNING] src/test/java/org/apache/nifi/processors/standard/TestGenerateTableFetch.java[41:8] (imports) UnusedImports: Unused import - java.sql.PreparedStatement. [WARNING] src/test/java/org/apache/nifi/processors/standard/TestGenerateTableFetch.java[57] (imports) AvoidStarImport: Using the '.*' form of import should be avoided - org.mockito.Mockito.*. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
