[GitHub] nifi issue #1618: NIFI-3413: Add GetChangeDataCaptureMySQL processor

2017-03-27 Thread mattyb149
Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/1618
  
@phrocker Thank you for the review! I reproduced your "no password" issue 
and found that BinaryLogClient expects a non-null password, so I added code to 
set the password to the empty string if none was provided in the property.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #1618: NIFI-3413: Add GetChangeDataCaptureMySQL processor

2017-03-24 Thread phrocker
Github user phrocker commented on the issue:

https://github.com/apache/nifi/pull/1618
  
@mattyb149  Cool stuff. I used your template because it was an easier place 
to start. Seems pretty good. I'll continue to test at my leisure but I'm happy 
with it presently. I tried to break it by stopping mysql mid cycle and 
BinaryLogClient handled it gracefully and all was well. Besides the NPE above 
I'm happy thus far. I'll continue to play with it for my own edification. Let 
me know if you wish me to test the NPE again or not. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #1618: NIFI-3413: Add GetChangeDataCaptureMySQL processor

2017-03-24 Thread phrocker
Github user phrocker commented on the issue:

https://github.com/apache/nifi/pull/1618
  
@mattyb149 I began with an empty password for my user and thus set an empty 
string. I saw an NPE in the logs, which did go away once I set a password for 
my user and subsequently set it in processor config. 


 2017-03-24 18:19:53,150 ERROR [blc-localhost:3306] org.apache.nifi.NiFi An 
Unknown Error Occurred in Thread Thread[blc-localhost:3306,5,main]: 
java.lang.NullPointerException
2017-03-24 18:19:53,155 ERROR [blc-localhost:3306] org.apache.nifi.NiFi 
java.lang.NullPointerException: null
  at 
com.github.shyiko.mysql.binlog.network.protocol.command.AuthenticateCommand.passwordCompatibleWithMySQL411(AuthenticateCommand.java:89)
 ~[mysql-binlog-connector-java-0.8.1.jar:na]
  at 
com.github.shyiko.mysql.binlog.network.protocol.command.AuthenticateCommand.toByteArray(AuthenticateCommand.java:70)
 ~[mysql-binlog-connector-java-0.8.1.jar:na]
  at 
com.github.shyiko.mysql.binlog.network.protocol.PacketChannel.write(PacketChannel.java:65)
 ~[mysql-binlog-connector-java-0.8.1.jar:na]
  at 
com.github.shyiko.mysql.binlog.BinaryLogClient.authenticate(BinaryLogClient.java:546)
 ~[mysql-binlog-connector-java-0.8.1.jar:na]
  at 
com.github.shyiko.mysql.binlog.BinaryLogClient.connect(BinaryLogClient.java:407)
 ~[mysql-binlog-connector-java-0.8.1.jar:na]
  at 
com.github.shyiko.mysql.binlog.BinaryLogClient$5.run(BinaryLogClient.java:635) 
~[mysql-binlog-connector-java-0.8.1.jar:na]
  at java.lang.Thread.run(Thread.java:745) ~[na:1.8.0_121]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #1618: NIFI-3413: Add GetChangeDataCaptureMySQL processor

2017-03-24 Thread phrocker
Github user phrocker commented on the issue:

https://github.com/apache/nifi/pull/1618
  
@mattyb149  I've left some minor comments. I'm going to pull this down and 
test this. I'm super excited. Looks cool. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---