[GitHub] nifi issue #1942: NIFI-4118 First commit of RethinkDB put processor
Github user mans2singh commented on the issue: https://github.com/apache/nifi/pull/1942 Thanks @jvwing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1942: NIFI-4118 First commit of RethinkDB put processor
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1942 Thanks @mans2singh! This has been merged in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1942: NIFI-4118 First commit of RethinkDB put processor
Github user mans2singh commented on the issue: https://github.com/apache/nifi/pull/1942 @joewitt @jvwing - Thanks for your review feedback. I've updated the notices as you had mentioned. Let me know if you have any other thoughts/recommendations. Mans --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1942: NIFI-4118 First commit of RethinkDB put processor
Github user mans2singh commented on the issue: https://github.com/apache/nifi/pull/1942 @jvwing - I've updated the code based on your comments. Please let me know if there is anything else required. Thanks again. Mans --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1942: NIFI-4118 First commit of RethinkDB put processor
Github user mans2singh commented on the issue: https://github.com/apache/nifi/pull/1942 Hi @jvwing - Thanks for your comments and feedback. I've updated the code (added RethinkDB site link to the description, renamed classes to match RethinkDB conventions, updated notice files and corrected the relation) based on your review. Regarding thread safety of the driver - as you pointed out, it is thread safe. Here is the pull request for thread safety (https://github.com/rethinkdb/rethinkdb/issues/5166). Please let me know if you have any additional observations/recommendations. Thanks again for your thorough review. Mans --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1942: NIFI-4118 First commit of RethinkDB put processor
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1942 @mans2singh, thanks for contributing this! I have a few general comments from a first pass: * The notice information for RethinkDB should be included in the nifi-assembly/NOTICE file. * The RethinkDB project styles it's name as "RethinkDB" with capitalized R, D, and B. I recommend we do the same in all of the user-visible processor naming, docs, property descriptions, etc. * The processor docs should include a link to the RethinkDB project. * Thanks for including a comprehensive test suite with solid code coverage. The integration tests also ran fine for me. And I have a question about connection management. I don't have any experience with RethinkDB. A brief search for documentation suggests that the Java connection might be thread safe ([RethinkDB Issue #1041](https://github.com/rethinkdb/docs/issues/1041)). Is that your understanding? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1942: NIFI-4118 First commit of RethinkDB put processor
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1942 Reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1942: NIFI-4118 First commit of RethinkDB put processor
Github user mans2singh commented on the issue: https://github.com/apache/nifi/pull/1942 Hey Folks: Can you please give me your feedback on this RethinkDB Put processor ? Thanks Mans --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1942: NIFI-4118 First commit of RethinkDB put processor
Github user mans2singh commented on the issue: https://github.com/apache/nifi/pull/1942 The integration tests failed because RethinkDB was not available. I've disabled the integration tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
