[GitHub] nifi issue #2015: NIFI-4142: Refactored Record Reader/Writer to allow for re...
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2015 went ahead and fixed the typo and squashed locally. Ran a test flow that created csv of various conformity to a simple spec. Ran it through various configratuions of the validator and it behaved as desired and expected in each case. When data was marked invalid was able to see precisely why through the provenance events which was great. Was able to see coercion/non-coercion behavior and all checks out. +1 merging to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2015: NIFI-4142: Refactored Record Reader/Writer to allow for re...
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2015 @markap14 looks like the option says "Used Reader's Schema". I'm assuming that is a typo and it should say "Use Reader's Schema". But that is not in this PR it appears. Did that sneak in elsewhere? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2015: NIFI-4142: Refactored Record Reader/Writer to allow for re...
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2015 @markap14 can you please rebase and resolve conflict and please go ahead and squash. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2015: NIFI-4142: Refactored Record Reader/Writer to allow for re...
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2015 @joewitt I've pushed a new commit that I believe better clarifies how schemas are treated in terms of strictness vs. leniency by providing two arguments instead of 'enforceSchema': 'coerceTypes' and 'dropUnknownFields' --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
