[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2180 +1 LGTM, ran unit tests and a number of scenarios on a live NiFi instance, verified the expected behavior with and without incoming flow files, loop connections, success/original/failure relationships, etc. Thanks for this addition! Merging to master ---
[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2180 @mattyb149 Changes are in and it's building. ---
[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2180 I will review this when I finish reviewing PR 2085. ---
[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2180 Sorry I havenât had time to close the loop on this. @alopresto if the suggested changes are in and you can run some tests successfully, then Iâm good, thanks! ---
[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2180 @alopresto got time to do that review? ---
[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2180 It looks like you and @mattyb149 have had very productive conversations around this. I'm a bit out of the loop on it but if Matt can't get to it by tomorrow, I'll do a final review and merge it if it looks good. ---
[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2180 @alopresto Can you merge this? ---
[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2180 @mattyb149 This should be ready for merge now. ---
[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2180 Ok. Did the merge and both GetMongoTest and RunMongoAggregationTest passed (didn't forget to comment out the @ignore statements...) ---
[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2180 There's a conflict now, can you rebase? I will try to take a look as soon as I can afterwards... ---
[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2180 @mattyb149 Any chance we can get this merged? ---
[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2180 @mattyb149 We should be good to go now. I just checked in a change that addresses the few minor points left over. ---
[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2180 @mattyb149 @alopresto I think all of the changes are in now. Any chance I could get this merged? ---
[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2180 @mattyb149 I think all of your changes are in now. I also updated GetMongo to harmonize some of the changes between it and RunMongoAggregation ---
[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2180 @joewitt I had it two weeks ago, so I understand. ---
[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2180 @MikeThomsen just as a headsup we've not forgotten about this. Mattyb picked up the flu thing that seems to be running wild. ---
[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2180 Ok Monday I will ;) ---
[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2180 Yes will review shortly ---
[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2180 @mattyb149 you be in a position to review this one soon by chance? ---
[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2180 @mattyb149 We should be good to go now. I ran it with GenerateFlowFile and got it to execute an aggregation query. ---
[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2180 @MikeThomsen not sure I'll get a chance before the New Year, but I will take a look when I get some time ---
[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2180 @mattyb149 If you get a chance, could you take a look? I just rebased it against master. ---
[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2180 @mbolka I think the PMC are backlogged. If you really need this, try asking someone on the dev mailing list to jump in on it. I'll have time in the next day or two to make any updates they request in order to get it merged. ---
[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user mbolka commented on the issue: https://github.com/apache/nifi/pull/2180 When is this branch going to be merged? ---
[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user milanchandna commented on the issue: https://github.com/apache/nifi/pull/2180 Yes I reviewed, changes looks good. But I am myself a fresh contributor so IMO you should wait for expert review to get this merged. ---
[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2180 @alopresto @milanchandna Can you take a look at the changes when you get a chance? ---
[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2180 @mattyb149 @markap14 @milanchandna Do any of you have some time to do a quick look to see if this can get merged? ---
[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2180 @mattyb149 @markap14 @milanchandna Did some cleanup and rebased against 1.5.0-SNAPSHOT. ---
