[GitHub] nifi issue #2184: NIFI-4441 : add maprecord support for avro union types

2017-10-11 Thread frett27 
Github user frett27 commented on the issue:

https://github.com/apache/nifi/pull/2184
  
Thank's matt, new pull request associated : #2207, hope this will help the 
review


---

[GitHub] nifi issue #2184: NIFI-4441 : add maprecord support for avro union types

2017-10-11 Thread mattyb149 
Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/2184
  
This branch looks out of whack with the current master, can you start with 
a fresh master and cherry-pick in your commits for this issue? It will help 
with merging and review, thanks!


---

[GitHub] nifi issue #2184: NIFI-4441 : add maprecord support for avro union types

2017-10-08 Thread frett27 
Github user frett27 commented on the issue:

https://github.com/apache/nifi/pull/2184
  
Modified the test resource files to remove any projet references, 
fix style


---

[GitHub] nifi issue #2184: NIFI-4441 : add maprecord support for avro union types

2017-10-06 Thread joewitt 
Github user joewitt commented on the issue:

https://github.com/apache/nifi/pull/2184
  
We cannot take a document/source/item from some place unless it has a 
clear/compatible license for it.  If there isn't one at all or isn't one that 
is favorable to our needs as an ASF project we cannot use it.  So either we use 
all originally created source or we cite it.  Does that make sense?


---

[GitHub] nifi issue #2184: NIFI-4441 : add maprecord support for avro union types

2017-10-04 Thread frett27 
Github user frett27 commented on the issue:

https://github.com/apache/nifi/pull/2184
  
Hi, markap14, the definition is mine for the tests, and yes on top of the 
osm definition, i think there is no license associated issue. And yes could be 
more interesting for have a separate file for ease the reading.



---

[GitHub] nifi issue #2184: NIFI-4441 : add maprecord support for avro union types

2017-10-03 Thread markap14 
Github user markap14 commented on the issue:

https://github.com/apache/nifi/pull/2184
  
@frett27 thanks for your contribution! It looks like you're provided some 
test data that is used in a unit test. Any idea what the license would be on 
this test data? I'm guessing from looking at it that it was provided by 
osm.org? If licensing information is not available, it may make sense to just 
create some mock-up data instead?


---