[GitHub] nifi issue #2443: NIFI-4827 Added support for reading queries from the flowf...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2443 @mattyb149 Any chance you can take a look? ---
[GitHub] nifi issue #2443: NIFI-4827 Added support for reading queries from the flowf...
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2443 Merging #2180 caused a conflict on this PR, mind rebasing against the latest master? Please and thanks! ---
[GitHub] nifi issue #2443: NIFI-4827 Added support for reading queries from the flowf...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2443 NP. I'll try to get that done in a little bit. ---
[GitHub] nifi issue #2443: NIFI-4827 Added support for reading queries from the flowf...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2443 @mattyb149 Rebased and pushed. Building now. ---
[GitHub] nifi issue #2443: NIFI-4827 Added support for reading queries from the flowf...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2443 @mattyb149 Passed the test and it says it's ready. ---
[GitHub] nifi issue #2443: NIFI-4827 Added support for reading queries from the flowf...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2443 @mattyb149 I have time today that if you can get to this I can switch over to 4838 and get that ready for close out too. ---
[GitHub] nifi issue #2443: NIFI-4827 Added support for reading queries from the flowf...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2443 @mattyb149 Ready for review. ---
[GitHub] nifi issue #2443: NIFI-4827 Added support for reading queries from the flowf...
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2443
@mattyb149 I broke the query location unit test down into three distinct
cases:
* Verify that an empty query w/ no flowfile defaults to timer-driven
behavior with `{}` as the query.
* Verify that a query param will work when set.
* Verify that it can read from the body w/ EL support.
---
[GitHub] nifi issue #2443: NIFI-4827 Added support for reading queries from the flowf...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2443 Two of the 3 builds succeeded, and there are now five tests that cover the "read query" behavior so I think the tires have been pretty well kicked on this one. ---
[GitHub] nifi issue #2443: NIFI-4827 Added support for reading queries from the flowf...
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2443 +1 LGTM, ran unit tests and contrib-check, checked documentation and verified behavior on a NiFi instance, with and without incoming connections, Query parameter set, self-loops, etc. Thanks for the improvement! Merging to master ---
[GitHub] nifi issue #2443: NIFI-4827 Added support for reading queries from the flowf...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2443 Thanks. I'll rebase the other one and get started there. ---
[GitHub] nifi issue #2443: NIFI-4827 Added support for reading queries from the flowf...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2443 Ok. I just pushed some changes that should fix things with the query location issue. I took your advice on following the SQL approach. Unit tests are there and batter the heck out of it. ---
