[GitHub] nifi issue #2452: NIFI-4816: Allow name to be updated for ReportingTasks
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2452 @mattyb149 this looks good to me now! Thanks for updating. I'm not in a position to merge right now, but I will give it a +1 if you want to merge yourself. Otherwise I will merge when I get my local branch squared away. Thanks! ---
[GitHub] nifi issue #2452: NIFI-4816: Allow name to be updated for ReportingTasks
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2452 The idea for storing off the name for all reporting tasks is to support #2431 , in fact that's where this behavior was discovered. I like the @OnScheduled setName() idea, I may call it something more specific (rather than a bean method) since it will take a context. Will make the change, thanks! ---
[GitHub] nifi issue #2452: NIFI-4816: Allow name to be updated for ReportingTasks
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2452 @mattyb149 thanks for the update. This is definitely something that I think we should have added at the start. I'm curious about why the update to all of the reporting tasks, though. None of them make use of the name, as far as I can tell, so why both storing it off? Moreover, if we do want to store it off, then why not just have the setName() method have an @OnScheduled annotation and take in the ConfigurationContext. Then the abstract impl will automatically have the name set. It would not necessarily be available if being called from other @OnScheduled methods, but I think that's okay as long as it is documented - in such a case, you should call the method on the ReportingContext itself. ---
