[GitHub] nifi issue #2482: NIFI-4894: Ensuring that any proxy paths are retained when...

2018-02-20 Thread scottyaslan 
Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2482
  
Reviewing...


---

[GitHub] nifi issue #2482: NIFI-4894: Ensuring that any proxy paths are retained when...

2018-02-21 Thread scottyaslan 
Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2482
  
@mcgilman I have reviewed and built these changes and all looks good.


---

[GitHub] nifi issue #2482: NIFI-4894: Ensuring that any proxy paths are retained when...

2018-02-21 Thread jtstorck 
Github user jtstorck commented on the issue:

https://github.com/apache/nifi/pull/2482
  
@mcgilman @scottyaslan I was able to reproduce the bug in master while 
proxying with Knox by creating a HandleHttpRequest processor with a 
StandardHttpContextMap controller service.  Attempting to enable the service 
through the UI resulted in the 404.  After applying the PR to master and 
restarting, I was able to go through the same steps and successfully enable the 
StandardHttpContextMap controller service.

+1 LGTM!


---

[GitHub] nifi issue #2482: NIFI-4894: Ensuring that any proxy paths are retained when...

2018-02-21 Thread scottyaslan 
Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2482
  
Thanks @jtstorck! Thanks @mcgilman this has been merged to master.


---