[GitHub] nifi issue #2550: NIFI-4980: Typo in ReportAtlasLineage kafka kerberos servi...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2550 @ijokarumawak you can also reach out to @dmkoster for reviews on Atlas. ---
[GitHub] nifi issue #2550: NIFI-4980: Typo in ReportAtlasLineage kafka kerberos servi...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2550 Done. ---
[GitHub] nifi issue #2550: NIFI-4980: Typo in ReportAtlasLineage kafka kerberos servi...
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/2550 Thank you @mattyb149 @MikeThomsen for your comments. I agree with that. @MikeThomsen would you cherry-pick only the 1st commit into master branch? ---
[GitHub] nifi issue #2550: NIFI-4980: Typo in ReportAtlasLineage kafka kerberos servi...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2550 @ijokarumawak I say we just go ahead and merge a breaking change here. Atlas is not even at a stable 1.0 release, so anyone using it should be prepared for a few bumps as things get ironed out. If you want me to pare down the commit, let me know. I have some free time today. ---
[GitHub] nifi issue #2550: NIFI-4980: Typo in ReportAtlasLineage kafka kerberos servi...
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2550 I think the new property is overkill and agree with @MikeThomsen that correcting the typo should not impact many users in any serious fashion. If we don't want to impact anyone and keep the current UX, then since this is just a machine-friendly name not exposed to the user, I think we could just target this PR for NiFi 2.0 ---
[GitHub] nifi issue #2550: NIFI-4980: Typo in ReportAtlasLineage kafka kerberos servi...
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/2550 @pvillard31 @MikeThomsen I thought adding backward compatibility would make it complex, but it was not that much than I thought if I tried. I added another commit to add few more lines of code to support migration from old property to the new renamed one. It lets user to keep the reporting task running using the old configuration until they remove the old property. I think this approach will guide users to the right direction better than providing migration guide in release note. Thanks! ---
[GitHub] nifi issue #2550: NIFI-4980: Typo in ReportAtlasLineage kafka kerberos servi...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2550 @joewitt @pvillard31 I think the Atlas support and Atlas itself are sufficiently new that not many users would be affected if @ijokarumawak corrects a typo here. ---
[GitHub] nifi issue #2550: NIFI-4980: Typo in ReportAtlasLineage kafka kerberos servi...
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2550 Agree that's an overkill... What do you think @joewitt? Since you seem to be the next RM for NiFi 1.6.0, it could be enough to mention it in the release note? ---
[GitHub] nifi issue #2550: NIFI-4980: Typo in ReportAtlasLineage kafka kerberos servi...
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/2550 @pvillard31 Yes, it's a breaking change. I wrote a comment on the JIRA. https://issues.apache.org/jira/browse/NIFI-4980?focusedCommentId=16400035&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16400035 Should we implement some migration code? I was concerning about that, too, but didn't want to make it to complex for this little change.. ---
[GitHub] nifi issue #2550: NIFI-4980: Typo in ReportAtlasLineage kafka kerberos servi...
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2550 Hey @ijokarumawak, I'm a bit concerned by this change since this code has already been released in NiFi 1.5.0. I believe that changing the name() of this property could be a breaking change for people already using the reporting task, no? ---
