[GitHub] nifi issue #2615: NIFI-5051 Created ElasticSearch lookup service.
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2615 +1 LGTM, ran full build with unit tests, tried the lookup service with a nested record and everything worked fine. Thanks for the improvement! Merging to master ---
[GitHub] nifi issue #2615: NIFI-5051 Created ElasticSearch lookup service.
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2615 [ES_Lookup_Test.xml.txt](https://github.com/apache/nifi/files/2386507/ES_Lookup_Test.xml.txt) [5051 Kibana Commands](https://github.com/apache/nifi/files/2386508/5051.kibana.txt) [docker-compose.yml.txt](https://github.com/apache/nifi/files/2386510/docker-compose.yml.txt) ---
[GitHub] nifi issue #2615: NIFI-5051 Created ElasticSearch lookup service.
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2615 Reviewing... ---
[GitHub] nifi issue #2615: NIFI-5051 Created ElasticSearch lookup service.
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2615 @mattyb149 can we close this out? ---
[GitHub] nifi issue #2615: NIFI-5051 Created ElasticSearch lookup service.
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2615 @mattyb149 can we merge? ---
[GitHub] nifi issue #2615: NIFI-5051 Created ElasticSearch lookup service.
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2615 @MikeThomsen I would maybe put a comment in the `src/test/java/.gitignore` file explaining why it's there so someone in the future doesn't see it as a superfluous tooling artifact and remove it, and then your test is silently no longer executed and we don't catch regressions. We've had similar occurrences in some of the other modules. ---
[GitHub] nifi issue #2615: NIFI-5051 Created ElasticSearch lookup service.
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2615 Should be all good to go now. ---
[GitHub] nifi issue #2615: NIFI-5051 Created ElasticSearch lookup service.
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2615 @mattyb149 Refactored the query builder. ---
[GitHub] nifi issue #2615: NIFI-5051 Created ElasticSearch lookup service.
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2615 @pvillard31 @mattyb149 changes checked in. ---
[GitHub] nifi issue #2615: NIFI-5051 Created ElasticSearch lookup service.
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2615 @mattyb149 @pvillard31 Changed the query model as requested and it's ready for final review AFAICT. ---
[GitHub] nifi issue #2615: NIFI-5051 Created ElasticSearch lookup service.
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2615 @mattyb149 changed the query model per the discussion above and changed the tests to be Groovy so that the inline JSON, etc. would be a lot cleaner to read. ---
[GitHub] nifi issue #2615: NIFI-5051 Created ElasticSearch lookup service.
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2615 Reviewing... ---
[GitHub] nifi issue #2615: NIFI-5051 Created ElasticSearch lookup service.
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2615 @mattyb149 I converted it over to be a subclass of `SchemaRegistryService`. Let me know if it needs anything else. ---
[GitHub] nifi issue #2615: NIFI-5051 Created ElasticSearch lookup service.
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2615 @mattyb149 Can you comment on the schema detection strategy issue I raised here? ---
[GitHub] nifi issue #2615: NIFI-5051 Created ElasticSearch lookup service.
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2615 @mattyb149 Done. ---
