[GitHub] nifi issue #2648: NIFI-4942 Fix unit test salt assertion regex
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/2648 @kevdoran LGTM +1. Contrib-check at Travis passed and locally as well. Merging. ---
[GitHub] nifi issue #2648: NIFI-4942 Fix unit test salt assertion regex
Github user kevdoran commented on the issue: https://github.com/apache/nifi/pull/2648 Aside from the issue with the ./secure_hash.key file being created in an odd location, all other issues should be addressed now. If someone can verify (the more platforms we have coverage on, the better) that would be much appreciated. ---
[GitHub] nifi issue #2648: NIFI-4942 Fix unit test salt assertion regex
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2648 for good measure those tests fail whether I'm parallel building or not so fortunately it is repeatable...was worried it was due to parallel building ---
[GitHub] nifi issue #2648: NIFI-4942 Fix unit test salt assertion regex
Github user kevdoran commented on the issue: https://github.com/apache/nifi/pull/2648 Ok, thanks. good to know. I'll make that change and also fix or disable those tests. Will update soon ---
[GitHub] nifi issue #2648: NIFI-4942 Fix unit test salt assertion regex
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2648 I dont think so @kevdoran because it should be included by default going forward unless it were overridden in a lower level/module pom. The excludes line having combine.children is doing that so it says 'dont just exclude what I specify but rather exclude what I specify plus whatever was already excluded above' ---
[GitHub] nifi issue #2648: NIFI-4942 Fix unit test salt assertion regex
Github user kevdoran commented on the issue: https://github.com/apache/nifi/pull/2648 Thanks for taking a look @joewitt. I'll try a build on Linux and try to reproduce that. I agree on placing the consoleOutput=true setting in the root pom. Does it also need to be included in every submodule that respecifies this plugin (i.e., the modules that configure their own exclusion)? ---
[GitHub] nifi issue #2648: NIFI-4942 Fix unit test salt assertion regex
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2648 to clarify regarding the above i was seeing that on a linux system. Travis-CI did pass. ---
[GitHub] nifi issue #2648: NIFI-4942 Fix unit test salt assertion regex
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2648 @kevdoran i like the changes for travis using the igores file input to grep! Left a comment to consider moving consoleOutput of rat to the top level pom. And I am still seeing test issues for > [ERROR] Tests run: 130, Failures: 5, Errors: 0, Skipped: 2, Time elapsed: 14.497 s <<< FAILURE! - in org.apache.nifi.properties.ConfigEncryptionToolTest [ERROR] testShouldMigrateFromHashedPasswordToKey(org.apache.nifi.properties.ConfigEncryptionToolTest) Time elapsed: 0.029 s <<< FAILURE! java.lang.AssertionError: Wrong exit status expected:<0> but was:<4> [ERROR] testShouldMigrateFromHashedPasswordToPassword(org.apache.nifi.properties.ConfigEncryptionToolTest) Time elapsed: 0.391 s <<< FAILURE! java.lang.AssertionError: Wrong exit status expected:<0> but was:<4> [ERROR] testShouldMigrateFromHashedKeyToKey(org.apache.nifi.properties.ConfigEncryptionToolTest) Time elapsed: 0.009 s <<< FAILURE! java.lang.AssertionError: Wrong exit status expected:<0> but was:<4> [ERROR] testShouldMigrateFromHashedKeyToPassword(org.apache.nifi.properties.ConfigEncryptionToolTest) Time elapsed: 0.377 s <<< FAILURE! java.lang.AssertionError: Wrong exit status expected:<0> but was:<4> [ERROR] testShouldReturnCurrentHashParams(org.apache.nifi.properties.ConfigEncryptionToolTest) Time elapsed: 0.008 s <<< FAILURE! java.lang.AssertionError: Wrong exit status expected:<0> but was:<10> ---
