[GitHub] nifi issue #2679: NIFI-5141: Updated regex for doubles to allow for numbers ...

2018-06-04 Thread mattyb149 
Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/2679
  
+1 LGTM, all tests pass, merging based on Ed's +1, thanks for the 
improvement (and to Ed for the review!) Merging to master


---

[GitHub] nifi issue #2679: NIFI-5141: Updated regex for doubles to allow for numbers ...

2018-05-15 Thread bdesert 
Github user bdesert commented on the issue:

https://github.com/apache/nifi/pull/2679
  
+1.
No more comments from my side.


---

[GitHub] nifi issue #2679: NIFI-5141: Updated regex for doubles to allow for numbers ...

2018-05-15 Thread markap14 
Github user markap14 commented on the issue:

https://github.com/apache/nifi/pull/2679
  
@bdesert good call! I updated the regex so that it allows for expressions 
like "13." and added a unit test that tests lots of different possible 
combinations. Thanks!


---