[GitHub] nifi issue #2742: NIFI-5244 Fixed a bug in MockSchemaRegistry that prevented...

2018-05-29 Thread bbende 
Github user bbende commented on the issue:

https://github.com/apache/nifi/pull/2742
  
Looks good, will merge, thanks!


---

[GitHub] nifi issue #2742: NIFI-5244 Fixed a bug in MockSchemaRegistry that prevented...

2018-05-29 Thread ottobackwards 
Github user ottobackwards commented on the issue:

https://github.com/apache/nifi/pull/2742
  
+1 looks good to me


---

[GitHub] nifi issue #2742: NIFI-5244 Fixed a bug in MockSchemaRegistry that prevented...

2018-05-29 Thread MikeThomsen 
Github user MikeThomsen commented on the issue:

https://github.com/apache/nifi/pull/2742
  
Yep. At first I thought it was something clever, so I tried it out w/ a 
simple Java class and `ConcurrentHashMap` doesn't handle optionals.


---

[GitHub] nifi issue #2742: NIFI-5244 Fixed a bug in MockSchemaRegistry that prevented...

2018-05-28 Thread ottobackwards 
Github user ottobackwards commented on the issue:

https://github.com/apache/nifi/pull/2742
  
So the issue was passing the optional instead of the value and never 
finding the schema?


---

[GitHub] nifi issue #2742: NIFI-5244 Fixed a bug in MockSchemaRegistry that prevented...

2018-05-27 Thread MikeThomsen 
Github user MikeThomsen commented on the issue:

https://github.com/apache/nifi/pull/2742
  
@markap14 @bbende could one of you review this?


---