[GitHub] nifi issue #2836: NIFI-5147 Calculate hash attribute redux

[ottobackwards]

Github user ottobackwards commented on the issue:

https://github.com/apache/nifi/pull/2836
  
Sure.  For Jira's when you want to do it yourself, I suggest assigning it.  
That is my habit on the other Apache things I work with, and it will help guard 
against eager beavers ;)

Thanks for using the work as much as you did.



---

[GitHub] nifi issue #2836: NIFI-5147 Calculate hash attribute redux

[alopresto]

Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/2836
  
I didn't capture every detail of the issue in the Jira because I planned on 
writing it myself. However, some of the behavior (empty input should still 
return a hash, etc.) was standard. Yes, please close this PR and review 2980. 


---

[GitHub] nifi issue #2836: NIFI-5147 Calculate hash attribute redux

[ottobackwards]

Github user ottobackwards commented on the issue:

https://github.com/apache/nifi/pull/2836
  
Ok, that is great.  Did I miss something that _was_ in the jira?
Should I just close this PR now then?


---

[GitHub] nifi issue #2836: NIFI-5147 Calculate hash attribute redux

[alopresto]

Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/2836
  
I started reviewing this PR but realized it did not implement many of the 
behaviors I had needed in the original ticket. I opened [PR 
2980](https://github.com/apache/nifi/pull/2980) which includes this foundation 
instead. 


---

[GitHub] nifi issue #2836: NIFI-5147 Calculate hash attribute redux

[ottobackwards]

Github user ottobackwards commented on the issue:

https://github.com/apache/nifi/pull/2836
  
Rebased on master, and fixed typos


---

[GitHub] nifi issue #2836: NIFI-5147 Calculate hash attribute redux

[ottobackwards]

Github user ottobackwards commented on the issue:

https://github.com/apache/nifi/pull/2836
  
@alopresto, just a ping.  It has been a while


---