[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2936 There are definitely inconsistencies throughout the project as this wasn't always a firm policy and there are many different contributors to the project. As you noted, we have tried to tighten the reviews and catch this where we can, and hopefully with the completion of [NIFI-5627](https://issues.apache.org/jira/browse/NIFI-5627), we will have a foundation to move forward on enabling EL in passwords for users. ---
[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...
Github user lukepfarrar commented on the issue: https://github.com/apache/nifi/pull/2936 I wondered if that was the case but it did not seem consistent with the DB pooling, which does/did allow EL in the password, althought I notice that the scope has been tightened in recent versions. Thanks :) ---
[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2936
Hi @lukepfarrar , we have a policy of not evaluating EL in password fields.
Here is [an example of that review
process](https://github.com/apache/nifi/pull/3020#discussion_r219712821) and
the reasoning behind it on another PR.
> Our policy so far has been that passwords do not support expression
language, for a couple reasons:
> 1. How to evaluate if a password `abc${def}` should be interpreted as
`abc` + *the value of(`def`)* or the literal string `abc${def}`
> 1. The variable registry is not designed to store sensitive values
securely, so if a password is stored here, it can be accessed by an
unauthorized user
---
[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...
Github user lukepfarrar commented on the issue: https://github.com/apache/nifi/pull/2936 Is there a reason why USER supports el but PASSWORD does not? ---
[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...
Github user danieljimenez commented on the issue: https://github.com/apache/nifi/pull/2936 FWIW I am currently using a SNAPSHOT from 01782bf on a real RabbitMQ server. ---
[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...
Github user mosermw commented on the issue: https://github.com/apache/nifi/pull/2936 +1 from me, though I didn't test this against a real RabbitMQ server. @zenfenan did you want to take another look? ---
[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...
Github user danieljimenez commented on the issue: https://github.com/apache/nifi/pull/2936 @mosermw Port added sir. :) ---
[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...
Github user mosermw commented on the issue: https://github.com/apache/nifi/pull/2936 Please do add Port to your PR, if you can, then I think this will also cover NIFI-4723. It looks like PORT_VALIDATOR already supports expression language, so you are good there. ---
[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...
Github user danieljimenez commented on the issue: https://github.com/apache/nifi/pull/2936 @mosermw I can, I just enabled the fields most likely to be variables for most use cases. If you'd like me to add that to this PR, I certainly can. ---
[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...
Github user mosermw commented on the issue: https://github.com/apache/nifi/pull/2936 If you are using VARIABLE_REGISTRY to dynamically evaluate the Host, shouldn't you also allow it for Port? ---
[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2936 @danieljimenez correct, PRs merged now will be included in the next release. Because our *bug fix* releases (`x.x.1`) do not include feature work, this will be in the next *minor* release, which is `1.8.0`. ---
[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...
Github user danieljimenez commented on the issue: https://github.com/apache/nifi/pull/2936 Missed a spot evaluating the attribute expressions. Fixed. ---
[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...
Github user danieljimenez commented on the issue: https://github.com/apache/nifi/pull/2936 Awesome, thanks! That would mean it's targeted for 1.8.0, correct? ---
[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...
Github user danieljimenez commented on the issue: https://github.com/apache/nifi/pull/2936 After rerunning the Travis failures are gone. ---
[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...
Github user danieljimenez commented on the issue: https://github.com/apache/nifi/pull/2936 No idea what the travis failures are, they are definitely not related to this change. ---
