[GitHub] nifi issue #2956: NIFI-5537 Create Neo4J cypher execution processor
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2956 @mans2singh before we continue, do you mind joining in [this discussion](http://apache-nifi-developer-list.39713.n7.nabble.com/Graph-database-support-w-NiFi-tp18680p19706.html) that I reopened on the mailing list? ---
[GitHub] nifi issue #2956: NIFI-5537 Create Neo4J cypher execution processor
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2956 > @MikeThomsen - Regarding your graph output questions - It looks correct but can you please let me know what are the commands/files that were ingested for above output ? I'll try to find some time to replay and get back to you on that. ---
[GitHub] nifi issue #2956: NIFI-5537 Create Neo4J cypher execution processor
Github user mans2singh commented on the issue: https://github.com/apache/nifi/pull/2956 @MikeThomsen - Regarding your graph output questions - Can you please let me know what are the commands/files that were ingested for above output ? ---
[GitHub] nifi issue #2956: NIFI-5537 Create Neo4J cypher execution processor
Github user mans2singh commented on the issue: https://github.com/apache/nifi/pull/2956 Rebased against master. ---
[GitHub] nifi issue #2956: NIFI-5537 Create Neo4J cypher execution processor
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2956 @mans2singh you're going to need to do a rebase off of master. ---
[GitHub] nifi issue #2956: NIFI-5537 Create Neo4J cypher execution processor
Github user mans2singh commented on the issue: https://github.com/apache/nifi/pull/2956 @MikeThomsen - There is a docker compose file in the nifi-neo4j-examples project mentioned above. Note that to avoid any conflict with standalone server - the ports exposed in docker compose are different from the default neo4j server. ---
[GitHub] nifi issue #2956: NIFI-5537 Create Neo4J cypher execution processor
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2956 Did a `mvn dependency:tree` on the bundle and only `neo4j-java-driver` was new for the whole build. Checked it out so we seem to be good on the dependencies being at least compatibly licensed. ---
[GitHub] nifi issue #2956: NIFI-5537 Create Neo4J cypher execution processor
Github user mans2singh commented on the issue: https://github.com/apache/nifi/pull/2956 @ottobackwards Thanks for your comments. @joewitt - Please let me know if you have any advice/pointers for me. ---
[GitHub] nifi issue #2956: NIFI-5537 Create Neo4J cypher execution processor
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2956 @mans2singh This is great PR. +1 from me. You still need a committer +1 though. ---
[GitHub] nifi issue #2956: NIFI-5537 Create Neo4J cypher execution processor
Github user mans2singh commented on the issue: https://github.com/apache/nifi/pull/2956 @ottobackwards - I've update the code/documentation based on your feedback. Please let me know if you have any additional advice for me. Mans ---
[GitHub] nifi issue #2956: NIFI-5537 Create Neo4J cypher execution processor
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2956 One question I have, do we have to be concerned with which version of neo4j works with the driver version we are using? Does that need to be documented? "Known to work with versions ."? ---
[GitHub] nifi issue #2956: NIFI-5537 Create Neo4J cypher execution processor
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2956 Thanks @mans2singh. I'll definitely try to run through this. ---
[GitHub] nifi issue #2956: NIFI-5537 Create Neo4J cypher execution processor
Github user mans2singh commented on the issue: https://github.com/apache/nifi/pull/2956 Hello @ottobackwards I've documented the steps for setting up neo4j and testing this processor in a project [nifi-neo4j-examples](https://github.com/mans2singh/nifi-flow-examples/tree/nifi-neo4j-examples) (branch nifi-neo4j-examples). The project's [README.md](https://github.com/mans2singh/nifi-flow-examples/blob/nifi-neo4j-examples/README.md) has the steps, along with input sample files (creating a node, select all the nodes, delete nodes, etc) and a NIFI Neo4J sample template. The nifi-neo4j-processors project also has full suite of integration tests which can be executed after setting up neo4j. Please let me know if this helps, If you have andy feedback or advice for me, please let me know. Thanks again. Mans ---
[GitHub] nifi issue #2956: NIFI-5537 Create Neo4J cypher execution processor
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2956 @mans2singh I'm not sure how to test this. I don't use/have neo4j. If you know a reviewer who does, you may want to tag them. I won't be able to review without some testing instructions in the PR, including simple running of neo4j with data to test statements against. ---
[GitHub] nifi issue #2956: NIFI-5537 Create Neo4J cypher execution processor
Github user mans2singh commented on the issue: https://github.com/apache/nifi/pull/2956 Hi @ottobackwards @joewitt I've renamed the bundle based on your feedback. Please let me know if you have any more comments/feedback. Thanks for your advice. ---
[GitHub] nifi issue #2956: NIFI-5537 Create Neo4J cypher execution processor
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2956 Just having it called nifi-neo4j-bundle is probably sufficient. The intent with the bundles is to put like things with like dependencies together. It is about creating an isolated classloader but at the same time we dont want 'one per component'. Also, unless the resulting nar is extremely small we probably dont want to add it to the nifi-assembly at this time. It is ok, still available, just not in the default build. Lastly, remember with the L&N files that we must account for *all* dependencies in the nar. I didn't check so it might be fine but a reminder. ---
[GitHub] nifi issue #2956: NIFI-5537 Create Neo4J cypher execution processor
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2956 That seems to be the convention from what I can see, and then there would be multiple neo4j processors, maybe services, service-api, common utils under there. ---
[GitHub] nifi issue #2956: NIFI-5537 Create Neo4J cypher execution processor
Github user mans2singh commented on the issue: https://github.com/apache/nifi/pull/2956 @ottobackwards - I am open to changing the name to your recommendation. Mans ---
[GitHub] nifi issue #2956: NIFI-5537 Create Neo4J cypher execution processor
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2956 Just a quick comment. Why not just a neo4j bundle? I think that is the convention ---
