[GitHub] nifi issue #2988: NIFI-5574 Removed usage of Paths.get() due to TEST_RES_PAT...
Github user nalewis commented on the issue: https://github.com/apache/nifi/pull/2988 Yep all good there! ``` [INFO] --- [INFO] T E S T S [INFO] --- [INFO] Running org.apache.nifi.NiFiGroovyTest [INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.517 s - in org.apache.nifi.NiFiGroovyTest [INFO] [INFO] Results: [INFO] [INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 18.564 s [INFO] Finished at: 2018-09-19T10:10:55-05:00 [INFO] Final Memory: 27M/267M [INFO] ``` ---
[GitHub] nifi issue #2988: NIFI-5574 Removed usage of Paths.get() due to TEST_RES_PAT...
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2988 @nalewis Can you run the specific NiFiGroovyTest via maven successfully? ---
[GitHub] nifi issue #2988: NIFI-5574 Removed usage of Paths.get() due to TEST_RES_PAT...
Github user nalewis commented on the issue: https://github.com/apache/nifi/pull/2988 @jtstorck Got dragged away to other projects and wanted to get back to this. Trying to build on your branch at the moment. With `mvn clean install -T C2 -DskipTests` I can successfully build, however with `mvn clean install` I fail same as you did on your VM with the `TestFileSystemRepository` errors. ---
[GitHub] nifi issue #2988: NIFI-5574 Removed usage of Paths.get() due to TEST_RES_PAT...
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2988 @nalewis We'd have to investigate if the cause for the TestMinimalLockingWriteAheadLog.testRecoverFileThatHasTrailingNULBytesAndTruncation test failing is the same as what's documented in [NIFI-5344](https://issues.apache.org/jira/browse/NIFI-5344) or if it's a new issue. ---
[GitHub] nifi issue #2988: NIFI-5574 Removed usage of Paths.get() due to TEST_RES_PAT...
Github user nalewis commented on the issue: https://github.com/apache/nifi/pull/2988 I'm on Windows 10. ---
[GitHub] nifi issue #2988: NIFI-5574 Removed usage of Paths.get() due to TEST_RES_PAT...
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2988 Regarding this PR, on my Windows 7 desktop, the NiFiGroovyTest in nifi-runtime passes: ``` [INFO] --- [INFO] T E S T S [INFO] --- [INFO] Running org.apache.nifi.NiFiGroovyTest [INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.103 s - in org.apache.nifi.NiFiGroovyTest [INFO] [INFO] Results: [INFO] [INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] [INFO] BUILD SUCCESS [INFO] ``` Given that the changes made in this PR are only in the nifi-runtime module, **I think this PR can be merged**. The full build, skipping tests and no contrib-check (`mvn clean install -T C2 -DskipTests`) is successful. However, the full build with contrib-check on, and tests skipped (`mvn clean install -T C2 -Pcontrib-check`), or running Apache RAT exclusively (`mvn apache-rat:check`) fails the RAT check in nifi-poi-processors. ``` Files with unapproved licenses: C:/Users/Jeff/dev/git-repos/nifi/nifi-nar-bundles/nifi-poi-bundle/nifi-poi-processors/src/test/resources/Unsupported.xls ``` Also, some tests are failing when I'm running the full build. For instance, in the nifi-file-authorizer module, some FileAuthorizer tests fail, but they pass if I run those tests by invoking the tests in nifi-file-authorizer specifically (from the nifi-file-authorizer module, running `mvn test -Dtest=FileAuthorizerTest`). There are also Toolkit CLI tests that are failing: ``` [ERROR] testWhenAllDescriptionsAreEmpty(org.apache.nifi.toolkit.cli.impl.result.writer.TestDynamicTableWriter) Time elapsed: 0 s <<< FAILURE! org.junit.ComparisonFailure: expected:<[ # Name IdDescription - --- --- 1 Bucket 1 12345-12345-12345-12345-12345-12345 (empty) 2 Bucket 2 12345-12345-12345-12345-12345-12345 (empty) ] > but was:<[ # Name IdDescription - --- --- 1 Bucket 1 12345-12345-12345-12345-12345-12345 (empty) 2 Bucket 2 12345-12345-12345-12345-12345-12345 (empty) ] > ``` The output looks the same to the eye, but the actual value tested against the expected value fails because the EOL characters are different. In TestDynamicTableWriter.java, the expected values in the tests use "\n" for EOL, and if they are changed to "\r\n", the test passes on Windows. JIRAs will have to be filed to go through the tests and updated them to use File.separator instead of explicitly using "\n". @nalewis [PR 2819](https://github.com/apache/nifi/pull/2819) was merged to master on June 28, 2018, and is this PR is branched off of master from yesterday. Those changes are already incorporated. What version of Windows are you running? ---
[GitHub] nifi issue #2988: NIFI-5574 Removed usage of Paths.get() due to TEST_RES_PAT...
Github user nalewis commented on the issue: https://github.com/apache/nifi/pull/2988 I grabbed the branch and attempted a clean install this morning. It failed with the following: mvn --version ``` Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T02:58:13-05:00) Maven home: C:\Program Files\apache-maven-3.5.2 Java version: 1.8.0_151, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk1.8.0_151\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" ``` ``` --- T E S T S --- Running org.wali.TestMinimalLockingWriteAheadLog Tests run: 12, Failures: 0, Errors: 1, Skipped: 2, Time elapsed: 6.653 sec <<< FAILURE! - in org.wali.TestMinimalLockingWriteAheadLog testRecoverFileThatHasTrailingNULBytesAndTruncation(org.wali.TestMinimalLockingWriteAheadLog) Time elapsed: 0.014 sec <<< ERROR! java.nio.channels.OverlappingFileLockException at org.wali.TestMinimalLockingWriteAheadLog.testRecoverFileThatHasTrailingNULBytesAndTruncation(TestMinimalLockingWriteAheadLog.java:472) Results : Tests in error: TestMinimalLockingWriteAheadLog.testRecoverFileThatHasTrailingNULBytesAndTruncation:472 â OverlappingFileLock Tests run: 12, Failures: 0, Errors: 1, Skipped: 2 ``` I'm seeing [this](https://github.com/apache/nifi/pull/2819) PR that had attempted to fix this issue. ---
[GitHub] nifi issue #2988: NIFI-5574 Removed usage of Paths.get() due to TEST_RES_PAT...
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2988 I created a Windows 10 VM via VirtualBox on my mac. With a fresh install of: - java ``` java version "1.8.0_181" Java(TM) SE Runtime Environment (build 1.8.0_181-b13) Java HotSpot(TM) 64-Bit Server VM (build 25.181-b13, mixed mode) ``` - maven ``` Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00) Maven home: C:\Users\Jeff\dev\apache-maven-3.5.4 Java version: 1.8.0_181, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jre1.8.0_181 Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" ``` I'm running into a build issue, with some failing tests: ``` [ERROR] TestStandardProcessSession.testBatchQueuedHaveSameQueuedTime:1690 Queued times should not be equal.. Actual: 1536116092889 ``` and quite a few `TestFileSystemRepository` tests due to issues in setup/shutdown like the following: ``` [ERROR] org.apache.nifi.controller.repository.TestFileSystemRepository.testBogusFile(org.apache.nifi.controller.repository.TestFileSystemRepository) [ERROR] Run 1: TestFileSystemRepository.setup:84 Unable to delete target\content_repository\1\1536116075082-1 expected null, but was: [ERROR] Run 2: TestFileSystemRepository.shutdown:94 NullPointer ``` This is probably due something related to running Windows in a VM and how I created it and/or the virtual disk. Tomorrow morning I'll try building on my Windows desktop to see if the same failures occur. ---
[GitHub] nifi issue #2988: NIFI-5574 Removed usage of Paths.get() due to TEST_RES_PAT...
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2988 I'll be testing this on my Windows machine tonight, but wanted to get the PR up ASAP for those that want to test this. ---
