[GitHub] nifi issue #3005: NIFI-5598: Allow JMS Processors to lookup Connection Facto...

2018-09-19 Thread mattyb149 
Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/3005
  
+1 LGTM, reviewed code and ran unit tests. @bdesert tried with success on a 
running system. Thanks for the improvement! Merging to master


---

[GitHub] nifi issue #3005: NIFI-5598: Allow JMS Processors to lookup Connection Facto...

2018-09-19 Thread bdesert 
Github user bdesert commented on the issue:

https://github.com/apache/nifi/pull/3005
  
+1. Ready for merge.
Tested JNDI lookup with Tibco Context Factory (with authentication). 
Successfully pulled records from my queue.



---

[GitHub] nifi issue #3005: NIFI-5598: Allow JMS Processors to lookup Connection Facto...

2018-09-18 Thread bdesert 
Github user bdesert commented on the issue:

https://github.com/apache/nifi/pull/3005
  
I'll test it and will let you know results (I have JNDI server with 
authentication for JMS queues).


---

[GitHub] nifi issue #3005: NIFI-5598: Allow JMS Processors to lookup Connection Facto...

2018-09-18 Thread markap14 
Github user markap14 commented on the issue:

https://github.com/apache/nifi/pull/3005
  
@bdesert thanks for the great feedback. I have pushed another commit.


---

[GitHub] nifi issue #3005: NIFI-5598: Allow JMS Processors to lookup Connection Facto...

2018-09-18 Thread markap14 
Github user markap14 commented on the issue:

https://github.com/apache/nifi/pull/3005
  
@bdesert  fair enough re: sensitive property & credentials.


---